Thread: Inconsistent use of --slot/-S in pg_receivexlog and pg_recvlogical
Hi, I noticed that pg_receivexlog is able to use --slot but not -S, even if the code is written this way. Attached is a patch correcting that. This makes pg_receivexlog consistent with pg_recvlogical regarding the slot option. IMHO, this should be backpatched to REL9_4_STABLE. Regards, -- Michael
Attachment
On Tue, Aug 12, 2014 at 4:50 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > Hi, > > I noticed that pg_receivexlog is able to use --slot but not -S, even > if the code is written this way. Attached is a patch correcting that. > This makes pg_receivexlog consistent with pg_recvlogical regarding the > slot option. > IMHO, this should be backpatched to REL9_4_STABLE. > Regards, Looks good to me. And, I could not find the reason why only -S was not added, in the past discussion. Anyway, barring any objection, I will commit this. Regards, -- Fujii Masao
On Tue, Aug 12, 2014 at 7:27 PM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Tue, Aug 12, 2014 at 4:50 PM, Michael Paquier > <michael.paquier@gmail.com> wrote: >> Hi, >> >> I noticed that pg_receivexlog is able to use --slot but not -S, even >> if the code is written this way. Attached is a patch correcting that. >> This makes pg_receivexlog consistent with pg_recvlogical regarding the >> slot option. >> IMHO, this should be backpatched to REL9_4_STABLE. >> Regards, > > Looks good to me. And, I could not find the reason why only -S was not > added, in the past discussion. > > Anyway, barring any objection, I will commit this. Applied. Thanks! Regards, -- Fujii Masao