Thread: Bug of pg_receivexlog -v

Hi,

In 9.2, pg_receivexlog -v has emitted the messages as follows at the
end of each WAL file.

pg_receivexlog: finished segment at 0/2000000 (timeline 1)
pg_receivexlog: finished segment at 0/3000000 (timeline 1)
pg_receivexlog: finished segment at 0/4000000 (timeline 1)

But, while reviewing the pg_receivexlog patch written by Furuya, I
found that 0b63291 had
broken this feature, and then now pg_receivexlog -v doesn't emit such
messages at all.
Attached patch fixes this problem. This needs to be back-patched to 9.3.

Regards,

--
Fujii Masao

On Fri, Aug 1, 2014 at 8:35 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> Hi,
>
> In 9.2, pg_receivexlog -v has emitted the messages as follows at the
> end of each WAL file.
>
> pg_receivexlog: finished segment at 0/2000000 (timeline 1)
> pg_receivexlog: finished segment at 0/3000000 (timeline 1)
> pg_receivexlog: finished segment at 0/4000000 (timeline 1)
>
> But, while reviewing the pg_receivexlog patch written by Furuya, I
> found that 0b63291 had
> broken this feature, and then now pg_receivexlog -v doesn't emit such
> messages at all.
> Attached patch fixes this problem. This needs to be back-patched to 9.3.

I found another problem on pg_receivexlog, which can cause the leak of
PGresult. The leak is small and rare, but it's better to fix that.
Patch attached.

Regards,

--
Fujii Masao

On Fri, Aug 1, 2014 at 8:35 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> Hi,
>
> In 9.2, pg_receivexlog -v has emitted the messages as follows at the
> end of each WAL file.
>
> pg_receivexlog: finished segment at 0/2000000 (timeline 1)
> pg_receivexlog: finished segment at 0/3000000 (timeline 1)
> pg_receivexlog: finished segment at 0/4000000 (timeline 1)
>
> But, while reviewing the pg_receivexlog patch written by Furuya, I
> found that 0b63291 had
> broken this feature, and then now pg_receivexlog -v doesn't emit such
> messages at all.
> Attached patch fixes this problem. This needs to be back-patched to 9.3.

Applied.

Regards,

-- 
Fujii Masao

On Sat, Aug 2, 2014 at 1:47 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Fri, Aug 1, 2014 at 8:35 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> Hi,
>>
>> In 9.2, pg_receivexlog -v has emitted the messages as follows at the
>> end of each WAL file.
>>
>> pg_receivexlog: finished segment at 0/2000000 (timeline 1)
>> pg_receivexlog: finished segment at 0/3000000 (timeline 1)
>> pg_receivexlog: finished segment at 0/4000000 (timeline 1)
>>
>> But, while reviewing the pg_receivexlog patch written by Furuya, I
>> found that 0b63291 had
>> broken this feature, and then now pg_receivexlog -v doesn't emit such
>> messages at all.
>> Attached patch fixes this problem. This needs to be back-patched to 9.3.
>
> I found another problem on pg_receivexlog, which can cause the leak of
> PGresult. The leak is small and rare, but it's better to fix that.
> Patch attached.

Applied.

Regards,

-- 
Fujii Masao