From: Murtuza Mukadam <murtuza.i.mukadam@gmail.com>
Date: Sat, Mar 8, 2014 at 1:56 PM
Subject: Re: [HACKERS] git-review: linking commits to review discussion in git
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: pgsql-hackers@postgresql.org
Hi Heikki
We have linked git commits and reviews in a web interface. If you
enter a commit hash, you will be redirected to the email archive of
the peer review discussion:
http://cesel.encs.concordia.ca/git-reviewed-tracker.php
This work is part of my thesis, so feedback is much appreciated. If
you have another git repo and mailing lists that you'd like linked,
please let us know.
Cheers,
Murtuza
How do we do the linking? We take each email patch, eliminate white
space and hash each line. We then compare the lines with those in
commits to the same files. The commit that changes the same files and
has the largest number of matching lines is considered to be the
reviewed commit.
On Tue, Jan 28, 2014 at 2:10 AM, Heikki Linnakangas
<hlinnakangas@vmware.com> wrote:
> On 01/27/2014 11:36 PM, Murtuza Mukadam wrote:
>>
>> Hello All,
>> We have linked peer review discussions on
>> 'pgsql-hackers' to their respective commits within the main
>> postgresql.git repository. You can view the linked reviews from 2012
>> until present in the GitHub repo at
>> https://github.com/mmukadam/postgres/tree/review
>>
>> If you want to work with these reviews locally, you can use our
>> git-review tool. It allows you to create reviews and attach them to
>> commits in git. We didn't modify git, instead we added some scripts
>> that use standard git commands. git-review is beta, but since it only
>> adds a detached 'review' branch and modifies the contents of this
>> branch, it has minimal impact and can easily be removed by deleting
>> the 'review' branch and scripts.
>>
>> The online man-page is here:
>> http://users.encs.concordia.ca/~m_mukada/git-review.html
>>
>> In order to install git-review, you need to clone the repository:
>> https://github.com/mmukadam/git-review.git
>>
>> The online tutorial is available here:
>> http://users.encs.concordia.ca/~m_mukada/git-review-tutorial.html
>>
>> The clone of postgresql.git with linked review discussion is here (new
>> review discussion are linked nightly)
>> https://github.com/mmukadam/postgres
>>
>> This work is part of my Master's thesis. If you'd like us to change
>> the tool to better suit your review process, have another git repo
>> you'd like us to link commits with review discussion, or have other
>> feedback, please let us know.
>
>
> I don't understand what this does. The repository at
> https://github.com/mmukadam/postgres looks like just a clone of the main
> PostgreSQL repository, with no extra links anywhere. And the repository at
> https://github.com/mmukadam/postgres/tree/review looks like a mailing list
> archive turned into a git repository, but I don't see any links to the
> commits in the main repository there.
>
> Am I missing something?
>
> - Heikki
