Thread: Warning in new GIN code

The rather ancient gcc on my HPUX box is complaining thusly about HEAD:

ginbtree.c: In function `ginPlaceToPage':
ginbtree.c:602: warning: control reaches end of non-void function

I would imagine this would happen on any compiler that doesn't recognize
the hint about elog(ERROR) not returning.  Could we stick a dummy return
at the end?
}else
+    {    elog(ERROR, "unknown return code from GIN placeToPage method: %d", rc);
+        return false;  /* keep compiler quiet */
+    }
}
        regards, tom lane

On 01/23/2014 08:41 PM, Tom Lane wrote:
> The rather ancient gcc on my HPUX box is complaining thusly about HEAD:
>
> ginbtree.c: In function `ginPlaceToPage':
> ginbtree.c:602: warning: control reaches end of non-void function
>
> I would imagine this would happen on any compiler that doesn't recognize
> the hint about elog(ERROR) not returning.  Could we stick a dummy return
> at the end?
>
>     }
>     else
> +    {
>         elog(ERROR, "unknown return code from GIN placeToPage method: %d", rc);
> +        return false;  /* keep compiler quiet */
> +    }
> }

Fixed, thanks.

- Heikki