Thread: pg_upgrade misreports full disk

When pg_upgrade encounters a full disk while copying relation files,
it reports this as:

error while copying relation "xyz" (...): Success

because it doesn't set errno in some error cases.  In other places we
treat short writes as ENOSPC, so here is a patch to do that for
pg_upgrade as well.

On Wed, Nov 13, 2013 at 10:28 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> When pg_upgrade encounters a full disk while copying relation files,
> it reports this as:
>
> error while copying relation "xyz" (...): Success
>
> because it doesn't set errno in some error cases.  In other places we
> treat short writes as ENOSPC, so here is a patch to do that for
> pg_upgrade as well.

+1 for committing this and back-patching it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company