Thread: make dist error

make dist error

From
Tatsuo Ishii
Date:
I'm getting errors while executing "make dist" on git master head.

$ make dist
make dist
rm -rf postgresql-9.4devel* =install=
for x in `cd . && find . \( -name CVS -prune \) -o \( -name .git -prune \) -o -print`; do \  file=`expr X$x :
'X\./\(.*\)'`;\  if test -d "./$file" ; then \    mkdir "postgresql-9.4devel/$file" && chmod 777
"postgresql-9.4devel/$file";   \  else \    ln "./$file" "postgresql-9.4devel/$file" >/dev/null 2>&1 \      || cp
"./$file""postgresql-9.4devel/$file"; \  fi || exit; \done
 
make -C postgresql-9.4devel distprep
[snip]
/bin/tar chf postgresql-9.4devel.tar postgresql-9.4devel
/bin/tar: postgresql-9.4devel/src/bin/pg_controldata/pg_crc.c: File removed before we read it
/bin/tar: postgresql-9.4devel/src/bin/pg_resetxlog/pg_crc.c: File removed before we read it
/bin/tar: postgresql-9.4devel/src/backend/tcop/.#postgres.c: File removed before we read it
make: *** [postgresql-9.4devel.tar] Error 1
make: *** Deleting file `postgresql-9.4devel.tar'
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp



Re: make dist error

From
Andrew Dunstan
Date:
On 07/16/2013 02:53 AM, Tatsuo Ishii wrote:
> I'm getting errors while executing "make dist" on git master head.
>
> $ make dist
> make dist
> rm -rf postgresql-9.4devel* =install=
> for x in `cd . && find . \( -name CVS -prune \) -o \( -name .git -prune \) -o -print`; do \
>       file=`expr X$x : 'X\./\(.*\)'`; \
>       if test -d "./$file" ; then \
>         mkdir "postgresql-9.4devel/$file" && chmod 777 "postgresql-9.4devel/$file";    \
>       else \
>         ln "./$file" "postgresql-9.4devel/$file" >/dev/null 2>&1 \
>           || cp "./$file" "postgresql-9.4devel/$file"; \
>       fi || exit; \
>     done
> make -C postgresql-9.4devel distprep
> [snip]
> /bin/tar chf postgresql-9.4devel.tar postgresql-9.4devel
> /bin/tar: postgresql-9.4devel/src/bin/pg_controldata/pg_crc.c: File removed before we read it
> /bin/tar: postgresql-9.4devel/src/bin/pg_resetxlog/pg_crc.c: File removed before we read it
> /bin/tar: postgresql-9.4devel/src/backend/tcop/.#postgres.c: File removed before we read it
> make: *** [postgresql-9.4devel.tar] Error 1
> make: *** Deleting file `postgresql-9.4devel.tar'

It's working for me:
   ...   /bin/tar chf postgresql-9.4devel.tar postgresql-9.4devel   gzip --best -c postgresql-9.4devel.tar
>postgresql-9.4devel.tar.gz  bzip2 -c postgresql-9.4devel.tar >postgresql-9.4devel.tar.bz2   rm -rf
postgresql-9.4devel

It looks like your source directory isn't completely clean. Before I did 
this I did:
   git clean -dfx


cheers

andrew




Re: make dist error

From
Tatsuo Ishii
Date:
> It's working for me:
> 
>    ...
>    /bin/tar chf postgresql-9.4devel.tar postgresql-9.4devel
>    gzip --best -c postgresql-9.4devel.tar >postgresql-9.4devel.tar.gz
>    bzip2 -c postgresql-9.4devel.tar >postgresql-9.4devel.tar.bz2
>    rm -rf postgresql-9.4devel
> 
> It looks like your source directory isn't completely clean. Before I
> did this I did:
> 
>    git clean -dfx

Oh, I didn't know that "make dist" requires git clean. Thanks.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp



Re: make dist error

From
Andrew Dunstan
Date:
On 07/16/2013 09:53 AM, Andrew Dunstan wrote:
>
> On 07/16/2013 02:53 AM, Tatsuo Ishii wrote:
>> I'm getting errors while executing "make dist" on git master head.
>>
>> $ make dist
>> make dist
>> rm -rf postgresql-9.4devel* =install=
>> for x in `cd . && find . \( -name CVS -prune \) -o \( -name .git 
>> -prune \) -o -print`; do \
>>       file=`expr X$x : 'X\./\(.*\)'`; \
>>       if test -d "./$file" ; then \
>>         mkdir "postgresql-9.4devel/$file" && chmod 777 
>> "postgresql-9.4devel/$file";    \
>>       else \
>>         ln "./$file" "postgresql-9.4devel/$file" >/dev/null 2>&1 \
>>           || cp "./$file" "postgresql-9.4devel/$file"; \
>>       fi || exit; \
>>     done
>> make -C postgresql-9.4devel distprep
>> [snip]
>> /bin/tar chf postgresql-9.4devel.tar postgresql-9.4devel
>> /bin/tar: postgresql-9.4devel/src/bin/pg_controldata/pg_crc.c: File 
>> removed before we read it
>> /bin/tar: postgresql-9.4devel/src/bin/pg_resetxlog/pg_crc.c: File 
>> removed before we read it
>> /bin/tar: postgresql-9.4devel/src/backend/tcop/.#postgres.c: File 
>> removed before we read it
>> make: *** [postgresql-9.4devel.tar] Error 1
>> make: *** Deleting file `postgresql-9.4devel.tar'
>
> It's working for me:
>
>    ...
>    /bin/tar chf postgresql-9.4devel.tar postgresql-9.4devel
>    gzip --best -c postgresql-9.4devel.tar >postgresql-9.4devel.tar.gz
>    bzip2 -c postgresql-9.4devel.tar >postgresql-9.4devel.tar.bz2
>    rm -rf postgresql-9.4devel
>
> It looks like your source directory isn't completely clean. Before I 
> did this I did:
>
>    git clean -dfx


Incidentally, the buildfarm animal guaibasaurus builds "make dist" every 
build, via a bespoke buildfarm module. See for example 
<http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=guaibasaurus&dt=2013-07-16%2004%3A17%3A01&stg=make-dist>, 
so we should get early notice if anything breaks it.


cheers

andrew



Re: make dist error

From
Peter Eisentraut
Date:
On 7/16/13 10:03 AM, Andrew Dunstan wrote:
> Incidentally, the buildfarm animal guaibasaurus builds "make dist" every
> build, via a bespoke buildfarm module. See for example
> <http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=guaibasaurus&dt=2013-07-16%2004%3A17%3A01&stg=make-dist>,
> so we should get early notice if anything breaks it.

Ditto for my Jenkins:
http://pgci.eisentraut.org/jenkins/job/postgresql_master_dist/

So this is well covered.

The requirement to clean before make dist is perhaps underdocumented.