Thread: Add more regression tests for ASYNC

Add more regression tests for ASYNC

From
Robins Tharakan
Date:
Hi,

Patch to add more regression tests to ASYNC (/src/backend/commands/async).
Take code-coverage from 39% to 75%.

Any and all feedback is obviously welcome.

p.s.: Please let me know whether these tests are useless or would not be committed owing to unrelated reasons. As also, if these tests need to be clubbed (bundled up in 2-3) and submitted as a single submit.
--
Robins Tharakan
Attachment

Re: Add more regression tests for ASYNC

From
Josh Berkus
Date:
On 05/13/2013 05:37 PM, Robins Tharakan wrote:
> Hi,
> 
> Patch to add more regression tests to ASYNC (/src/backend/commands/async).
> Take code-coverage from 39% to 75%.

This isn't applying for me anymore due to changes in the
parallel_schedule file.  Where did you mean this to execute in the
sequence of tests?

--- src/test/regress/parallel_schedule
+++ src/test/regress/parallel_schedule
@@ -88,7 +88,7 @@# ----------# Another group of parallel tests# ----------
-test: alter_generic misc psql
+test: alter_generic misc psql async
# rules cannot run concurrently with any test that creates a viewtest: rules

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



Re: Add more regression tests for ASYNC

From
Josh Berkus
Date:
On 06/28/2013 12:42 PM, Josh Berkus wrote:
> On 05/13/2013 05:37 PM, Robins Tharakan wrote:
>> Hi,
>>
>> Patch to add more regression tests to ASYNC (/src/backend/commands/async).
>> Take code-coverage from 39% to 75%.
> 
> This isn't applying for me anymore due to changes in the
> parallel_schedule file.  Where did you mean this to execute in the
> sequence of tests?

Never mind, dirty checkout on my part.  Back to testing.


-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



Re: Add more regression tests for ASYNC

From
Robert Haas
Date:
On Mon, May 13, 2013 at 8:37 PM, Robins Tharakan <tharakan@gmail.com> wrote:
> Hi,
>
> Patch to add more regression tests to ASYNC (/src/backend/commands/async).
> Take code-coverage from 39% to 75%.
>
> Any and all feedback is obviously welcome.
>
> p.s.: Please let me know whether these tests are useless or would not be
> committed owing to unrelated reasons. As also, if these tests need to be
> clubbed (bundled up in 2-3) and submitted as a single submit.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company