Thread: Matview patch added rewriteDefine.c.orig to the repository

Matview patch added rewriteDefine.c.orig to the repository

From

Boszormenyi Zoltan

Date:

04 March 2013, 09:39:28

Hi,

commit 3bf3ab8c563699138be02f9dc305b7b77a724307
("Add a materialized view relations.") added this:
 src/backend/rewrite/rewriteDefine.c.orig        | 945 +++++++++++++...
... create mode 100644 src/backend/rewrite/rewriteDefine.c.orig

Committers should be more careful if they want to do work late Sunday.
I know, Monday begins on Saturday[1], but still... ;-)

[1] http://en.wikipedia.org/wiki/Monday_Begins_on_Saturday

Best regards,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de     http://www.postgresql.at/

Re: Matview patch added rewriteDefine.c.orig to the repository

From

Simon Riggs

Date:

04 March 2013, 10:02:18

On 4 March 2013 06:39, Boszormenyi Zoltan <zb@cybertec.at> wrote:

> commit 3bf3ab8c563699138be02f9dc305b7b77a724307
> ("Add a materialized view relations.") added this:
>
>  src/backend/rewrite/rewriteDefine.c.orig        | 945 +++++++++++++...
> ...
>  create mode 100644 src/backend/rewrite/rewriteDefine.c.orig
>
> Committers should be more careful if they want to do work late Sunday.
> I know, Monday begins on Saturday[1], but still... ;-)

AFAICS Kevin fixed this last night...

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services

Re: Matview patch added rewriteDefine.c.orig to the repository

From

Devrim Gündüz

Date:

04 March 2013, 10:10:54

Hi,<br /><br /> Kevin already removed it with a followup commit:<br /><br /><a
href="http://git.postgresql.org/pg/commitdiff/d63977eea3ab18fdec05e370b633d10b9fd20179">http://git.postgresql.org/pg/commitdiff/d63977eea3ab18fdec05e370b633d10b9fd20179</a><br
/><br/> Regards, Devrim<br /><br /><div class="gmail_quote">Boszormenyi Zoltan <zb@cybertec.at> wrote:<blockquote
class="gmail_quote"style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left:
1ex;"><prestyle="white-space: pre-wrap; word-wrap:break-word; font-family: sans-serif; margin-top: 0px">Hi,<br /><br
/>commit3bf3ab8c563699138be02f9dc305b7b77a724307<br />("Add a materialized view relations.") added this:<br /><br
/>src/backend/rewrite/rewriteDefine.c.orig       | 945 +++++++++++++...<br />...<br />create mode 100644
src/backend/rewrite/rewriteDefine.c.orig<br/><br />Committers should be more careful if they want to do work late
Sunday.<br/>I know, Monday begins on Saturday[1], but still... ;-)<br /><br />[1] <a
href="http://en.wikipedia.org/wiki/Monday_Begins_on_Saturday">http://en.wikipedia.org/wiki/Monday_Begins_on_Saturday</a><br
/><br/>Best regards,<br />Zoltán Böszörményi<br /></pre></blockquote></div><br /> --<br /> Devrim Gündüz

Re: Matview patch added rewriteDefine.c.orig to the repository

From

Boszormenyi Zoltan

Date:

04 March 2013, 12:55:17

2013-03-04 08:02 keltezéssel, Simon Riggs írta:
> On 4 March 2013 06:39, Boszormenyi Zoltan <zb@cybertec.at> wrote:
>
>> commit 3bf3ab8c563699138be02f9dc305b7b77a724307
>> ("Add a materialized view relations.") added this:
>>
>>   src/backend/rewrite/rewriteDefine.c.orig        | 945 +++++++++++++...
>> ...
>>   create mode 100644 src/backend/rewrite/rewriteDefine.c.orig
>>
>> Committers should be more careful if they want to do work late Sunday.
>> I know, Monday begins on Saturday[1], but still... ;-)
> AFAICS Kevin fixed this last night...
>

Did he? I just did this:

[zozo@localhost postgresql]$ git branch -a
* master  remotes/origin/HEAD -> origin/master  remotes/origin/REL2_0B  remotes/origin/REL6_4
remotes/origin/REL6_5_PATCHES remotes/origin/REL7_0_PATCHES  remotes/origin/REL7_1_STABLE  remotes/origin/REL7_2_STABLE
remotes/origin/REL7_3_STABLE  remotes/origin/REL7_4_STABLE  remotes/origin/REL8_0_STABLE  remotes/origin/REL8_1_STABLE
remotes/origin/REL8_2_STABLE remotes/origin/REL8_3_STABLE  remotes/origin/REL8_4_STABLE
remotes/origin/REL8_5_ALPHA1_BRANCH remotes/origin/REL8_5_ALPHA2_BRANCH  remotes/origin/REL8_5_ALPHA3_BRANCH
remotes/origin/REL9_0_ALPHA4_BRANCH remotes/origin/REL9_0_ALPHA5_BRANCH  remotes/origin/REL9_0_STABLE
remotes/origin/REL9_1_STABLE remotes/origin/REL9_2_STABLE  remotes/origin/Release_1_0_3  remotes/origin/WIN32_DEV
remotes/origin/ecpg_big_bison remotes/origin/master 
[zozo@localhost postgresql]$ cat .git/config
[core]    repositoryformatversion = 0    filemode = true    bare = false    logallrefupdates = true
[remote "origin"]    fetch = +refs/heads/*:refs/remotes/origin/*    url = git://git.postgresql.org/git/postgresql.git
[branch "master"]    remote = origin    merge = refs/heads/master
[zozo@localhost postgresql]$ git pull origin
Already up-to-date.
[zozo@localhost postgresql]$ find . -name "*.orig"
./src/backend/rewrite/rewriteDefine.c.orig

The main repo at http://git.postgresql.org/gitweb/?p=postgresql.git;a=summary
only shows one followup commit (just as in my local copy):
bc61878682051678ade5f59da7bfd90ab72ce13b
"Fix map_sql_value_to_xml_value() to treat domains like their base types."

In which branch was this fixed?

Thanks,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de     http://www.postgresql.at/

Re: Matview patch added rewriteDefine.c.orig to the repository

From

Boszormenyi Zoltan

Date:

04 March 2013, 12:55:57

<div class="moz-cite-prefix">2013-03-04 08:10 keltezéssel, Devrim Gündüz írta:<br /></div><blockquote
cite="mid:665044b2-d6b0-4dd5-a826-8f4c9e61faff@email.android.com"type="cite">Hi,<br /><br /> Kevin already removed it
witha followup commit:<br /><br /><a
href="http://git.postgresql.org/pg/commitdiff/d63977eea3ab18fdec05e370b633d10b9fd20179"
moz-do-not-send="true">http://git.postgresql.org/pg/commitdiff/d63977eea3ab18fdec05e370b633d10b9fd20179</a><br
/></blockquote><br/><br /> 404 - Unknown commit object<br /><br /><br /><blockquote
cite="mid:665044b2-d6b0-4dd5-a826-8f4c9e61faff@email.android.com"type="cite"><br /> Regards, Devrim<br /><br /><div
class="gmail_quote">BoszormenyiZoltan <a class="moz-txt-link-rfc2396E"
href="mailto:zb@cybertec.at"><zb@cybertec.at></a>wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt        0.8ex; border-left: 1px solid rgb(204, 204, 204);         padding-left: 1ex;"><pre style="white-space:
pre-wrap;word-wrap:break-word; font-family: sans-serif; margin-top: 0px">Hi, 

commit 3bf3ab8c563699138be02f9dc305b7b77a724307
("Add a materialized view relations.") added this:

src/backend/rewrite/rewriteDefine.c.orig        | 945 +++++++++++++...
...
create mode 100644 src/backend/rewrite/rewriteDefine.c.orig

Committers should be more careful if they want to do work late Sunday.
I know, Monday begins on Saturday[1], but still... ;-)

[1] <a href="http://en.wikipedia.org/wiki/Monday_Begins_on_Saturday"
moz-do-not-send="true">http://en.wikipedia.org/wiki/Monday_Begins_on_Saturday</a>

Best regards,
Zoltán Böszörményi
</pre></blockquote></div><br /> --<br /> Devrim Gündüz </blockquote><br /><br /><pre class="moz-signature" cols="90">--

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: <a class="moz-txt-link-freetext" href="http://www.postgresql-support.de">http://www.postgresql-support.de</a>
<aclass="moz-txt-link-freetext" href="http://www.postgresql.at/">http://www.postgresql.at/</a> 
</pre>

Re: Matview patch added rewriteDefine.c.orig to the repository

From

Magnus Hagander

Date:

04 March 2013, 15:01:23

<p dir="ltr"><br /> On Mar 4, 2013 10:55 AM, "Boszormenyi Zoltan" <<a
href="mailto:zb@cybertec.at">zb@cybertec.at</a>>wrote:<br /> ><br /> > 2013-03-04 08:02 keltezéssel, Simon
Riggsírta:<br /> ><br /> >> On 4 March 2013 06:39, Boszormenyi Zoltan <<a
href="mailto:zb@cybertec.at">zb@cybertec.at</a>>wrote:<br /> >><br /> >>> commit
3bf3ab8c563699138be02f9dc305b7b77a724307<br/> >>> ("Add a materialized view relations.") added this:<br />
>>><br/> >>>   src/backend/rewrite/rewriteDefine.c.orig        | 945 +++++++++++++...<br />
>>>...<br /> >>>   create mode 100644 src/backend/rewrite/rewriteDefine.c.orig<br /> >>><br
/>>>> Committers should be more careful if they want to do work late Sunday.<br /> >>> I know, Monday
beginson Saturday[1], but still... ;-)<br /> >><br /> >> AFAICS Kevin fixed this last night...<br />
>><br/> ><br /> > Did he? I just did this:<br /> ><br /> > [zozo@localhost postgresql]$ git branch
-a<br/> > * master<br /> >   remotes/origin/HEAD -> origin/master<br /> >   remotes/origin/REL2_0B<br />
>  remotes/origin/REL6_4<br /> >   remotes/origin/REL6_5_PATCHES<br /> >   remotes/origin/REL7_0_PATCHES<br />
>  remotes/origin/REL7_1_STABLE<br /> >   remotes/origin/REL7_2_STABLE<br /> >  
remotes/origin/REL7_3_STABLE<br/> >   remotes/origin/REL7_4_STABLE<br /> >   remotes/origin/REL8_0_STABLE<br />
>  remotes/origin/REL8_1_STABLE<br /> >   remotes/origin/REL8_2_STABLE<br /> >  
remotes/origin/REL8_3_STABLE<br/> >   remotes/origin/REL8_4_STABLE<br /> >  
remotes/origin/REL8_5_ALPHA1_BRANCH<br/> >   remotes/origin/REL8_5_ALPHA2_BRANCH<br /> >  
remotes/origin/REL8_5_ALPHA3_BRANCH<br/> >   remotes/origin/REL9_0_ALPHA4_BRANCH<br /> >  
remotes/origin/REL9_0_ALPHA5_BRANCH<br/> >   remotes/origin/REL9_0_STABLE<br /> >  
remotes/origin/REL9_1_STABLE<br/> >   remotes/origin/REL9_2_STABLE<br /> >   remotes/origin/Release_1_0_3<br />
>  remotes/origin/WIN32_DEV<br /> >   remotes/origin/ecpg_big_bison<br /> >   remotes/origin/master<br /> >
[zozo@localhostpostgresql]$ cat .git/config<br /> > [core]<br /> >     repositoryformatversion = 0<br /> >    
filemode= true<br /> >     bare = false<br /> >     logallrefupdates = true<br /> > [remote "origin"]<br />
>    fetch = +refs/heads/*:refs/remotes/origin/*<br /> >     url = git://<a
href="http://git.postgresql.org/git/postgresql.git">git.postgresql.org/git/postgresql.git</a><br/> > [branch
"master"]<br/> >     remote = origin<br /> >     merge = refs/heads/master<br /> > [zozo@localhost
postgresql]$git pull origin<br /> > Already up-to-date.<br /> > [zozo@localhost postgresql]$ find . -name
"*.orig"<br/> > ./src/backend/rewrite/rewriteDefine.c.orig<br /> ><br /> > The main repo at <a
href="http://git.postgresql.org/gitweb/?p=postgresql.git;a=summary">http://git.postgresql.org/gitweb/?p=postgresql.git;a=summary</a><br
/>> only shows one followup commit (just as in my local copy):<br /> >
bc61878682051678ade5f59da7bfd90ab72ce13b<br/> > "Fix map_sql_value_to_xml_value() to treat domains like their base
types."<br/> ><br /> > In which branch was this fixed?<p dir="ltr">The repository is currently broken. There's a
threadon www about it, and also see the email to hackers a few hours ago telling committers to stop pushing until it's
fixed.<p dir="ltr">/Magnus

Re: Matview patch added rewriteDefine.c.orig to the repository

From

Boszormenyi Zoltan

Date:

04 March 2013, 15:40:52

2013-03-04 13:01 keltezéssel, Magnus Hagander írta:
>
> The repository is currently broken. There's a thread on www about it, and also see the
> email to hackers a few hours ago telling committers to stop pushing until it's fixed.
>

Thanks for the info, I didn't know about it. I am not
subscribed to -www and I accidentally skipped your mail, too.

Best regards,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de     http://www.postgresql.at/