Thread: PGXS contrib builds broken?
Looks like the recent refactoring of code into common/ stopped PGXS builds within the PostgreSQL source tree from working, i get /Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32: fatal error: common/fe_memutils.h: No such file or directory when trying to build pg_upgrade, pgbench, pg_xlogdump, ... with PGXS. I don't see common/fe_memutils getting installed in include/, so i suppose either some bug between chair and keyboard or some inconsistencies here. -- Thanks Bernd
On 2013-02-25 11:50:46 +0100, Bernd Helmle wrote: > Looks like the recent refactoring of code into common/ stopped > PGXS builds within the PostgreSQL source tree from working, i get > > /Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32: > fatal error: common/fe_memutils.h: No such file or directory Oh, yes. It wasn't added to the install target during the src/common addition. Patch attached. > when trying to build pg_upgrade, pgbench, pg_xlogdump, ... with PGXS. > > I don't see common/fe_memutils getting installed in include/, so i suppose > either some bug between chair and keyboard or some inconsistencies here. pg_xlogdump won't be buildable without a full sourcetree around though, it needs too much backend infrastructure to be built... Thats why I voted somewhere else to remove PGXS support from it and error out instead... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
On 2013-02-26 13:57:46 +0100, Andres Freund wrote: > On 2013-02-25 11:50:46 +0100, Bernd Helmle wrote: > > Looks like the recent refactoring of code into common/ stopped > > PGXS builds within the PostgreSQL source tree from working, i get > > > > /Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32: > > fatal error: common/fe_memutils.h: No such file or directory > > Oh, yes. It wasn't added to the install target during the src/common > addition. Patch attached. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Attachment
Andres Freund <andres@2ndquadrant.com> writes:
> On 2013-02-26 13:57:46 +0100, Andres Freund wrote:
>> On 2013-02-25 11:50:46 +0100, Bernd Helmle wrote:
>>> Looks like the recent refactoring of code into common/ stopped
>>> PGXS builds within the PostgreSQL source tree from working, i get
>>> /Users/bernd/pgsql-dev/install/HEAD/include/server/postgres_fe.h:27:32:
>>> fatal error: common/fe_memutils.h: No such file or directory
>> Oh, yes. It wasn't added to the install target during the src/common
>> addition. Patch attached.
Pushed, thanks.
regards, tom lane