Thread: Release notes & git attribution

Hi,

The 9.2.3 release notes say:
* Fix pg_upgrade's -O/-o options (Bruce Momjian)

You got it the wrong way around, he was the one who introduced the bug! ;)

I originally found, debugged and provided the fix:
http://www.postgresql.org/message-id/CABRT9RBy1uRTMY-DfLDgBPCp+ZQU36M_+BLD4WFWuGOhg-M4hw@mail.gmail.com

No big deal, it was just one space, but I wanted to voice my
disagreement with how Postgres committers don't retain original patch
authorship information.

Regards,
Marti

On 8 February 2013 09:43, Marti Raudsepp <marti@juffo.org> wrote:

> No big deal, it was just one space, but I wanted to voice my
> disagreement with how Postgres committers don't retain original patch
> authorship information.

I agree its very important to get that right.

It's important for the PostgreSQL project to encourage further
contribution by acknowledging and celebrating contributions, as well
as allowing external observers to see that work was done successfully
by particular people to confirm further sponsorship/time allocation
etc. That practice has long been followed and encouraged by the core
team and committers.

Some mistakes are made from time to time but there is a willingness to
make corrections to that.

I'll look into this.

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services

Marti Raudsepp <marti@juffo.org> writes:
> The 9.2.3 release notes say:
> * Fix pg_upgrade's -O/-o options (Bruce Momjian)

> You got it the wrong way around, he was the one who introduced the bug! ;)

Sorry about that.  The release notes are made based on commit-log
entries.  In this case we had

Author: Bruce Momjian <bruce@momjian.us>
Branch: master [acdb8c225] 2012-12-10 23:03:25 -0500
Branch: REL9_2_STABLE [35fb1434b] 2012-12-10 23:03:28 -0500
   Fix pg_upgrade -O/-o options      Fix previous commit that added synchronous_commit=off, but broke -O/-o   due to
missingspace in argument passing.      Backpatch to 9.2.
 

so it was Bruce's error not to credit you in the commit message.
I know that he knows better --- it is project policy to properly credit
patch authors.  But mistakes do happen, of course.  Again, my apologies
on behalf of the project.
        regards, tom lane