Thread: [PATCH] PQping Docs
Attached is a patch that adds a note about the FATAL messages that appear in the logs if you don't pass a valid user or dbname to PQping or PQpingParams. This was requested in the pg_isready thread.
Attachment
On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber <phil@omniti.com> wrote: > Attached is a patch that adds a note about the FATAL messages that > appear in the logs if you don't pass a valid user or dbname to PQping > or PQpingParams. > > This was requested in the pg_isready thread. Can I counter-propose the attached, which puts the relevant text closer to the scene of the crime? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Attachment
On Wed, Jan 23, 2013 at 10:37 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber <phil@omniti.com> wrote: >> Attached is a patch that adds a note about the FATAL messages that >> appear in the logs if you don't pass a valid user or dbname to PQping >> or PQpingParams. >> >> This was requested in the pg_isready thread. > > Can I counter-propose the attached, which puts the relevant text > closer to the scene of the crime? > This seems reasonable to me. > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company
On Wed, Jan 23, 2013 at 10:59 AM, Phil Sorber <phil@omniti.com> wrote: > On Wed, Jan 23, 2013 at 10:37 AM, Robert Haas <robertmhaas@gmail.com> wrote: >> On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber <phil@omniti.com> wrote: >>> Attached is a patch that adds a note about the FATAL messages that >>> appear in the logs if you don't pass a valid user or dbname to PQping >>> or PQpingParams. >>> >>> This was requested in the pg_isready thread. >> >> Can I counter-propose the attached, which puts the relevant text >> closer to the scene of the crime? >> > This seems reasonable to me. OK, done. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company