Thread: S_ISLNK

Hi - I'm cross-compiling the master branch (cygwin/mingw) and have found a reference to S_ISLNK that isn't guarded by #ifndef WIN32 like the ones in basebackup.c are. Could you merge the attached fix? Thanks -

Nick

Nicholas White <n.j.white@gmail.com> writes:
> Hi - I'm cross-compiling the master branch (cygwin/mingw) and have found a
> reference to S_ISLNK that isn't guarded by #ifndef WIN32 like the ones in
> basebackup.c are.

That whole function is guarded by HAVE_READLINK, so I'm not seeing the
problem (and neither are the Windows members of the buildfarm).  What
environment are you in that has readlink() and not S_ISLNK?
        regards, tom lane

Ah - OK. It turns out I'd run ./configure in the postgresql directory
before running it in my build directory, so I had two (different)
pg_config.hs! The below builds for me from a clean source tree now.
Thanks -

Nick

./path/to/build/configure CC=x86_64-w64-mingw32-gcc
--target=x86_64-w64-mingw32 --build=x86_64-w64-mingw32
--host=x86_64-w64-mingw32 --without-readline --without-zlib
--disable-thread-safety

On 14 November 2012 06:25, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Nicholas White <n.j.white@gmail.com> writes:
>> Hi - I'm cross-compiling the master branch (cygwin/mingw) and have found a
>> reference to S_ISLNK that isn't guarded by #ifndef WIN32 like the ones in
>> basebackup.c are.
>
> That whole function is guarded by HAVE_READLINK, so I'm not seeing the
> problem (and neither are the Windows members of the buildfarm).  What
> environment are you in that has readlink() and not S_ISLNK?
>
>                         regards, tom lane