Thread: A typo fix in a comment in xlog.c

A typo fix in a comment in xlog.c

From
Kyotaro HORIGUCHI
Date:
Hello, I found a duplicate words in the comment of
StartupXLOG@xlog.c and the attached patch fixes it.


Essentially the fix is in one line as follows,

-  * We're in recovery, so unlogged relations relations may be trashed
+  * We're in recovery, so unlogged relations may be trashed

But I did fill-paragraph for the fixed comment so the patch
replaces a little bit more.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

== My e-mail address has been changed since Apr. 1, 2012.
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 0c301b2..04dec4e 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -6354,10 +6354,10 @@ StartupXLOG(void)        CheckRequiredParameterValues();        /*
-         * We're in recovery, so unlogged relations relations may be trashed
-         * and must be reset.  This should be done BEFORE allowing Hot Standby
-         * connections, so that read-only backends don't try to read whatever
-         * garbage is left over from before.
+         * We're in recovery, so unlogged relations may be trashed and must
+         * be reset.  This should be done BEFORE allowing Hot Standby
+         * connections, so that read-only backends don't try to read
+         * whatever garbage is left over from before.         */
ResetUnloggedRelations(UNLOGGED_RELATION_CLEANUP);

Re: A typo fix in a comment in xlog.c

From
Peter Eisentraut
Date:
On mån, 2012-04-16 at 21:28 +0900, Kyotaro HORIGUCHI wrote:
> Hello, I found a duplicate words in the comment of
> StartupXLOG@xlog.c and the attached patch fixes it.
> 
> 
> Essentially the fix is in one line as follows,
> 
> -  * We're in recovery, so unlogged relations relations may be trashed
> +  * We're in recovery, so unlogged relations may be trashed

Fixed.

> But I did fill-paragraph for the fixed comment so the patch
> replaces a little bit more.

You might want to adjust your fill-column setting to 79, so pgindent
doesn't reformat that again.  Compare to what I just committed.





Re: A typo fix in a comment in xlog.c

From
Kyotaro HORIGUCHI
Date:
> > But I did fill-paragraph for the fixed comment so the patch
> > replaces a little bit more.
> 
> You might want to adjust your fill-column setting to 79, so pgindent
> doesn't reformat that again.  Compare to what I just committed.

Thank you for sugestion. I could't decide fill-column fit to
every code and comments.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

== My e-mail address has been changed since Apr. 1, 2012.