Thread: Re: [COMMITTERS] pgsql: Speed up in-memory tuplesorting.
Robert Haas <rhaas@postgresql.org> writes:
> Speed up in-memory tuplesorting.
This patch appears to have broken those members of the buildfarm that
use VPATH builds. I assume you didn't think about the path to
qsort_tuple.c very carefully.
regards, tom lane
On Wed, Feb 15, 2012 at 2:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <rhaas@postgresql.org> writes: >> Speed up in-memory tuplesorting. > > This patch appears to have broken those members of the buildfarm that > use VPATH builds. I assume you didn't think about the path to > qsort_tuple.c very carefully. So it appears. I copied the rule that modifies errcodes.h, but clearly that's not enough. I think I might need to steal and adapt the following logic from src/backend/catalog/Makefile: # locations of headers that genbki.pl needs to read pg_includes = -I$(top_srcdir)/src/include/catalog -I$(top_builddir)/src/include/catalog I'll go test that now. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Wed, Feb 15, 2012 at 2:54 PM, Robert Haas <robertmhaas@gmail.com> wrote: > On Wed, Feb 15, 2012 at 2:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Robert Haas <rhaas@postgresql.org> writes: >>> Speed up in-memory tuplesorting. >> >> This patch appears to have broken those members of the buildfarm that >> use VPATH builds. I assume you didn't think about the path to >> qsort_tuple.c very carefully. > > So it appears. I copied the rule that modifies errcodes.h, but clearly > that's not enough. I think I might need to steal and adapt the > following logic from src/backend/catalog/Makefile: > > # locations of headers that genbki.pl needs to read > pg_includes = -I$(top_srcdir)/src/include/catalog > -I$(top_builddir)/src/include/catalog > > I'll go test that now. Nope, that's not it. Committed what seems to be the correct fix, after testing it locally. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company