Thread: Buffer overflow in contrib/test_parser/test_parser.c

Buffer overflow in contrib/test_parser/test_parser.c

From
Paul Guyot
Date:
Hello,

There is a buffer overflow in sample code's test_parser.c that can yield to a segmentation fault. The next byte of the
bufferis tested against ' ' before its availability is checked. 

You will find attached a simple patch that fixes the bug.

Paul
--
Semiocast            http://semiocast.com/
+33.183627948 - 20 rue Lacaze, 75014 Paris

Attachment

Re: Buffer overflow in contrib/test_parser/test_parser.c

From
Tom Lane
Date:
Paul Guyot <pguyot@kallisys.net> writes:
> There is a buffer overflow in sample code's test_parser.c that can yield to a segmentation fault. The next byte of
thebuffer is tested against ' ' before its availability is checked.
 

Hmm, yeah.  The probability of a failure is very low of course, but
still it'd be better if the sample code didn't have bugs like this.

> You will find attached a simple patch that fixes the bug.

Will apply, thank you.
        regards, tom lane