Thread: Replication timeout units
from postgresql.conf.sample: #replication_timeout = 60s # in milliseconds; 0 disables Seconds or milliseconds? I would suggest we just remove the "in milliseconds", and instead say "timeout for replication connections; 0 disables". -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
On 20 December 2011 13:38, Magnus Hagander <magnus@hagander.net> wrote: > from postgresql.conf.sample: > > #replication_timeout = 60s # in milliseconds; 0 disables > > Seconds or milliseconds? I would suggest we just remove the "in > milliseconds", and instead say "timeout for replication connections; 0 > disables". +1 from me. That's very confusing. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services
Peter Geoghegan <peter@2ndquadrant.com> wrote: > Magnus Hagander <magnus@hagander.net> wrote: >> from postgresql.conf.sample: >> >> #replication_timeout = 60s # in milliseconds; 0 disables >> >> Seconds or milliseconds? I would suggest we just remove the "in >> milliseconds", and instead say "timeout for replication >> connections; 0 disables". > > +1 from me. That's very confusing. Isn't it providing information on both the granularity and the default unit if none is specified? Why is it more confusing here than statement_timeout or any of the other places this pattern is followed? -1 from me on removing it *only* here. -Kevin
Magnus Hagander <magnus@hagander.net> writes:
> from postgresql.conf.sample:
> #replication_timeout = 60s # in milliseconds; 0 disables
> Seconds or milliseconds? I would suggest we just remove the "in
> milliseconds", and instead say "timeout for replication connections; 0
> disables".
That would take away any information about whether it could be set at
sub-second resolution. I don't like the current wording either, but
just removing the "in milliseconds" seems wrong.
regards, tom lane
On Tue, Dec 20, 2011 at 11:34:25AM -0600, Kevin Grittner wrote: > Peter Geoghegan <peter@2ndquadrant.com> wrote: > > Magnus Hagander <magnus@hagander.net> wrote: > >> from postgresql.conf.sample: > >> > >> #replication_timeout = 60s # in milliseconds; 0 disables > >> > >> Seconds or milliseconds? I would suggest we just remove the "in > >> milliseconds", and instead say "timeout for replication > >> connections; 0 disables". > > > > +1 from me. That's very confusing. > > Isn't it providing information on both the granularity and the > default unit if none is specified? Why is it more confusing here > than statement_timeout or any of the other places this pattern is > followed? > > -1 from me on removing it *only* here. FYI, I looked into this and can't see a way to improve it. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +