Thread: Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
From
Bruce Momjian
Date:
Tom Lane wrote: > Add temp_file_limit GUC parameter to constrain temporary file space usage. > > The limit is enforced against the total amount of temp file space used by > each session. > > Mark Kirkwood, reviewed by C?dric Villemain and Tatsuo Ishii Should we document that sessions that exceed this limit generate an error? I don't see any mention of this in the docs. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
From
Tom Lane
Date:
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> Add temp_file_limit GUC parameter to constrain temporary file space usage.
>>
>> The limit is enforced against the total amount of temp file space used by
>> each session.
>>
>> Mark Kirkwood, reviewed by C?dric Villemain and Tatsuo Ishii
> Should we document that sessions that exceed this limit generate an
> error? I don't see any mention of this in the docs.
Huh? Seems like a waste of text to me. What else would happen?
regards, tom lane
Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
From
Bruce Momjian
Date:
Tom Lane wrote: > Bruce Momjian <bruce@momjian.us> writes: > > Tom Lane wrote: > >> Add temp_file_limit GUC parameter to constrain temporary file space usage. > >> > >> The limit is enforced against the total amount of temp file space used by > >> each session. > >> > >> Mark Kirkwood, reviewed by C?dric Villemain and Tatsuo Ishii > > > Should we document that sessions that exceed this limit generate an > > error? I don't see any mention of this in the docs. > > Huh? Seems like a waste of text to me. What else would happen? Well, if we exceed work_mem, we spill to temp disk. If we exceed temp disk, we error out. Those different behaviors don't seem obvious to me. The work_mem docs do mention is spills to disk though, so maybe it is OK. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
Re: Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
From
Peter Eisentraut
Date:
On sön, 2011-07-17 at 18:39 -0400, Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <bruce@momjian.us> writes: > > > Tom Lane wrote: > > >> Add temp_file_limit GUC parameter to constrain temporary file space usage. > > >> > > >> The limit is enforced against the total amount of temp file space used by > > >> each session. > > >> > > >> Mark Kirkwood, reviewed by C?dric Villemain and Tatsuo Ishii > > > > > Should we document that sessions that exceed this limit generate an > > > error? I don't see any mention of this in the docs. > > > > Huh? Seems like a waste of text to me. What else would happen? > > Well, if we exceed work_mem, we spill to temp disk. If we exceed temp > disk, we error out. Those different behaviors don't seem obvious to me. > The work_mem docs do mention is spills to disk though, so maybe it is > OK. Sounds like it would be good to document the behavior if the limit is exceeded in each case.
Re: Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
From
Tom Lane
Date:
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> Huh? Seems like a waste of text to me. What else would happen?
> Well, if we exceed work_mem, we spill to temp disk. If we exceed temp
> disk, we error out. Those different behaviors don't seem obvious to me.
[ shrug... ] Feel free to change it.
regards, tom lane
Re: Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
From
Mark Kirkwood
Date:
On 19/07/11 02:36, Tom Lane wrote: > Bruce Momjian<bruce@momjian.us> writes: >> Tom Lane wrote: >>> Huh? Seems like a waste of text to me. What else would happen? >> Well, if we exceed work_mem, we spill to temp disk. If we exceed temp >> disk, we error out. Those different behaviors don't seem obvious to me. > [ shrug... ] Feel free to change it. > > No objections from me - can't see any harm in making it very clear what happens when the limit is exceeded :-)
Re: Re: [COMMITTERS] pgsql: Add temp_file_limit GUC parameter to constrain temporary file sp
From
Bruce Momjian
Date:
On Tue, Jul 19, 2011 at 10:29:45AM +1200, Mark Kirkwood wrote: > On 19/07/11 02:36, Tom Lane wrote: > >Bruce Momjian<bruce@momjian.us> writes: > >>Tom Lane wrote: > >>>Huh? Seems like a waste of text to me. What else would happen? > >>Well, if we exceed work_mem, we spill to temp disk. If we exceed temp > >>disk, we error out. Those different behaviors don't seem obvious to me. > >[ shrug... ] Feel free to change it. > > > > > > No objections from me - can't see any harm in making it very clear > what happens when the limit is exceeded :-) Documentation patch attached and applied, and backpatched to 9.2. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +