Thread: Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.
Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.
From
Robert Haas
Date:
On Fri, Feb 18, 2011 at 6:34 AM, Simon Riggs <simon@2ndquadrant.com> wrote: > Separate messages for standby replies and hot standby feedback. > Allow messages to be sent at different times, and greatly reduce > the frequency of hot standby feedback. Refactor to allow additional > message types. You could refactor this some more to avoid calling GetCurrentTimestamp() and TimestampDifferenceExceeds() twice each, but I'm not sure whether it's worth it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.
From
Simon Riggs
Date:
On Fri, 2011-02-18 at 07:11 -0500, Robert Haas wrote: > On Fri, Feb 18, 2011 at 6:34 AM, Simon Riggs <simon@2ndquadrant.com> wrote: > > Separate messages for standby replies and hot standby feedback. > > Allow messages to be sent at different times, and greatly reduce > > the frequency of hot standby feedback. Refactor to allow additional > > message types. > > You could refactor this some more to avoid calling > GetCurrentTimestamp() and TimestampDifferenceExceeds() twice each, but > I'm not sure whether it's worth it. Thanks for the observation. -- Simon Riggs http://www.2ndQuadrant.com/books/PostgreSQL Development, 24x7 Support, Training and Services