Thread: patch: Add PGXS support to hstore's Makefile (trivial)

patch: Add PGXS support to hstore's Makefile (trivial)

From
Joseph Adams
Date:
I discovered today that hstore's Makefile currently does not support
PGXS; namely, the ability to install it like so:

    USE_PGXS=1 make
    sudo USE_PGXS=1 make install

Moreover, hstore is the *only* contrib module whose Makefile does not
contain "PGXS".

The attached patch changes hstore's Makefile so it is like the others.
 I have tested the above commands on a copy of the hstore directory
located outside of the PostgreSQL source tree, and it appears to work
just fine.  I also tested conventional make and make install, and it
still appears to work as well.


Joey Adams

Attachment

Re: patch: Add PGXS support to hstore's Makefile (trivial)

From
Robert Haas
Date:
On Sun, Jan 23, 2011 at 9:20 PM, Joseph Adams
<joeyadams3.14159@gmail.com> wrote:
> The attached patch changes hstore's Makefile so it is like the others.

Thanks, committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: patch: Add PGXS support to hstore's Makefile (trivial)

From
Dimitri Fontaine
Date:
Robert Haas <robertmhaas@gmail.com> writes:

> On Sun, Jan 23, 2011 at 9:20 PM, Joseph Adams
> <joeyadams3.14159@gmail.com> wrote:
>> The attached patch changes hstore's Makefile so it is like the others.
>
> Thanks, committed.

For the record, I smell bitrot here:
 http://archives.postgresql.org/message-id/m21v7jpqe6.fsf@2ndQuadrant.fr

I had included this patch into my extension branch and patch, so this is
a good excuse for me to produce a v27.  Will do in a separate thread.

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support