Thread: some comments rewording in recovery.conf.sample about SR

some comments rewording in recovery.conf.sample about SR

From
"Jehan-Guillaume (ioguix) de Rorthais"
Date:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Hackers,

I believe comments in the recovery.conf.sample are somehow confusing
about standby and SR:
 # Edit this file to provide the parameters that PostgreSQL needs to # perform an archive recovery of a database, or to
actas a log-streaming # replication standby.
 

It seems incomplete. It doesn't recover OR act as a log-streaming
replication standby. It can behave as a standby node without SR as well.
 # When standby_mode is enabled, the PostgreSQL server will work as # a standby. It tries to connect to the primary
accordingto the # connection settings primary_conninfo, and receives XLOG records # continuously.
 

This one is quite unclear as well. We might think that once we are in
standby_mode we will be in SR. Again, we can use the standby_mode
without primary_conninfo. This parameter only allows to keep the cluster
in recovery, it doesn't imply to set up the SR.
 # By default, a standby server keeps streaming XLOG records from the # primary indefinitely.

Same story...

Please, find in attachment a proposal of rewording.

Comments ?

Regards,
- -- 
Jehan-Guillaume (ioguix) de Rorthais
www.dalibo.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0nBWAACgkQxWGfaAgowiJRlACfcXwFiGr1LlYuAPjwnOLIvoHl
SEAAoJbtNqG4bk1+htYKd9KALKCv/wCt
=q/x/
-----END PGP SIGNATURE-----


Re: some comments rewording in recovery.conf.sample about SR

From
"Jehan-Guillaume (ioguix) de Rorthais"
Date:
Obviously...

PFA

Le 07/01/2011 13:22, Jehan-Guillaume (ioguix) de Rorthais a écrit :
> Hello Hackers,
>
> I believe comments in the recovery.conf.sample are somehow confusing
> about standby and SR:
>
>   # Edit this file to provide the parameters that PostgreSQL needs to
>   # perform an archive recovery of a database, or to act as a log-streaming
>   # replication standby.
>
> It seems incomplete. It doesn't recover OR act as a log-streaming
> replication standby. It can behave as a standby node without SR as well.
>
>   # When standby_mode is enabled, the PostgreSQL server will work as
>   # a standby. It tries to connect to the primary according to the
>   # connection settings primary_conninfo, and receives XLOG records
>   # continuously.
>
> This one is quite unclear as well. We might think that once we are in
> standby_mode we will be in SR. Again, we can use the standby_mode
> without primary_conninfo. This parameter only allows to keep the cluster
> in recovery, it doesn't imply to set up the SR.
>
>   # By default, a standby server keeps streaming XLOG records from the
>   # primary indefinitely.
>
> Same story...
>
> Please, find in attachment a proposal of rewording.
>
> Comments ?
>
> Regards,

Attachment

Re: some comments rewording in recovery.conf.sample about SR

From
Robert Haas
Date:
On Fri, Jan 7, 2011 at 7:23 AM, Jehan-Guillaume (ioguix) de Rorthais
<ioguix@free.fr> wrote:
> PFA

Committed, with some additional wordsmithing.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: some comments rewording in recovery.conf.sample about SR

From
"Jehan-Guillaume (ioguix) de Rorthais"
Date:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 07/01/2011 16:58, Robert Haas a écrit :
> On Fri, Jan 7, 2011 at 7:23 AM, Jehan-Guillaume (ioguix) de Rorthais
> <ioguix@free.fr> wrote:
>> PFA
> 
> Committed, with some additional wordsmithing.

Thank you !
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0nS6sACgkQxWGfaAgowiL8ewCeNmThauDgdrJzp6npSSRCFroC
q0cAn2gnjSYH6g4Oodvre6trADT01RON
=6aSt
-----END PGP SIGNATURE-----