Thread: Re: [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

Re: [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

From
Robert Haas
Date:
On Fri, Jul 9, 2010 at 12:10 AM, Tom Lane <tgl@postgresql.org> wrote:
> Log Message:
> -----------
> Stamp HEAD as 9.1devel.
> (And there was much rejoicing.)

/me opens a beer.

How long should I wait before I start breaking things?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


Re: [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

From
"David E. Wheeler"
Date:
On Jul 8, 2010, at 9:20 PM, Robert Haas wrote:

> /me opens a beer.
>
> How long should I wait before I start breaking things?

I should think that you would need to drink at least 5-6 beers before you started stumbling around and breaking shit.

David




Re: [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

From
Tom Lane
Date:
Robert Haas <robertmhaas@gmail.com> writes:
>> Stamp HEAD as 9.1devel.
>> (And there was much rejoicing.)

> /me opens a beer.

> How long should I wait before I start breaking things?

Did you have any particular breakage in mind?

I'm hesitant to have a whole lot of variance between REL9_0_STABLE and
HEAD just yet, since we'll surely be doing a lot of double-patching for
awhile.  Localized patches, no problem, but this might not be the best
time to s/foo/bar/g or something like that.
        regards, tom lane


Re: [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

From
Robert Haas
Date:
On Fri, Jul 9, 2010 at 12:31 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>>> Stamp HEAD as 9.1devel.
>>> (And there was much rejoicing.)
>
>> /me opens a beer.
>
>> How long should I wait before I start breaking things?
>
> Did you have any particular breakage in mind?
>
> I'm hesitant to have a whole lot of variance between REL9_0_STABLE and
> HEAD just yet, since we'll surely be doing a lot of double-patching for
> awhile.  Localized patches, no problem, but this might not be the best
> time to s/foo/bar/g or something like that.

Well, you can see for yourself what I've submitted for the next CF.
As those things get reviewed, I'd like to get them committed; many of
them need follow-on patches in which I don't want to invest too much
effort until the initial patches go in.  And then, too, other people
have also submitted patches which I will be working on also.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


Re: [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

From
Tom Lane
Date:
Robert Haas <robertmhaas@gmail.com> writes:
>>> How long should I wait before I start breaking things?
>> 
>> Did you have any particular breakage in mind?

> Well, you can see for yourself what I've submitted for the next CF.

You might want to hold off on the get_whatever_oid patches for a bit,
but the other stuff I see there looks pretty localized.  No objection
to pressing forward with CF work otherwise.
        regards, tom lane


Re: [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

From
Robert Haas
Date:
On Fri, Jul 9, 2010 at 12:54 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>>>> How long should I wait before I start breaking things?
>>>
>>> Did you have any particular breakage in mind?
>
>> Well, you can see for yourself what I've submitted for the next CF.
>
> You might want to hold off on the get_whatever_oid patches for a bit,
> but the other stuff I see there looks pretty localized.  No objection
> to pressing forward with CF work otherwise.

I can hold off on those for a bit - I don't think there will be enough
drift to matter very much, but if it makes you more comfortable, it's
not a big deal.  What I really want to get committed is this one,
which is infrastructure for a further large patch:

include Backend ID in relpath for temp rels
https://commitfest.postgresql.org/action/patch_view?id=302

However, I need someone fairly knowledgeable to review it first.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


Re: [COMMITTERS] pgsql: Stamp HEAD as 9.1devel.

From
Robert Haas
Date:
On Fri, Jul 9, 2010 at 10:26 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Jul 9, 2010 at 12:54 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>>>> How long should I wait before I start breaking things?
>>>>
>>>> Did you have any particular breakage in mind?
>>
>>> Well, you can see for yourself what I've submitted for the next CF.
>>
>> You might want to hold off on the get_whatever_oid patches for a bit,
>> but the other stuff I see there looks pretty localized.  No objection
>> to pressing forward with CF work otherwise.
>
> I can hold off on those for a bit - I don't think there will be enough
> drift to matter very much, but if it makes you more comfortable, it's
> not a big deal.

I checked on these patches today and there was only one, quite trivial
conflict (and the relevant patch was not even something that was
back-patched).  So I think there is not much reason to hold off any
longer on committing these.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company