Thread: Re: [COMMITTERS] pgsql: Also update ChangerLog file.
Michael Meskes wrote: > Log Message: > ----------- > Also update ChangerLog file. Hmm not sure I find that commit message really helpful - but is it actually of any use to maintain a Changelog file specifically for ECPG? Stefan
On Fri, Jan 08, 2010 at 03:41:10PM +0100, Stefan Kaltenbrunner wrote: > Hmm not sure I find that commit message really helpful - but is it > actually of any use to maintain a Changelog file specifically for > ECPG? Makes it easier to see what's new in ecpg when doing a new release. But I guess we could get all this from the cvs log too. The file has been there for a long time. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL
Michael Meskes <meskes@postgresql.org> writes:
> On Fri, Jan 08, 2010 at 03:41:10PM +0100, Stefan Kaltenbrunner wrote:
>> Hmm not sure I find that commit message really helpful - but is it
>> actually of any use to maintain a Changelog file specifically for
>> ECPG?
> Makes it easier to see what's new in ecpg when doing a new
> release. But I guess we could get all this from the cvs log too. The
> file has been there for a long time.
Well, I'm pretty sure that release notes are prepared off of the cvs log
entries. I've never looked at ecpg's Changelog when working on notes,
and I'd be prepared to bet that Bruce hasn't either. My advice is to
drop the Changelog file and be sure you describe changes appropriately
in the commit messages.
regards, tom lane
On Sat, Jan 9, 2010 at 17:55, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Michael Meskes <meskes@postgresql.org> writes: >> On Fri, Jan 08, 2010 at 03:41:10PM +0100, Stefan Kaltenbrunner wrote: >>> Hmm not sure I find that commit message really helpful - but is it >>> actually of any use to maintain a Changelog file specifically for >>> ECPG? > >> Makes it easier to see what's new in ecpg when doing a new >> release. But I guess we could get all this from the cvs log too. The >> file has been there for a long time. > > Well, I'm pretty sure that release notes are prepared off of the cvs log > entries. I've never looked at ecpg's Changelog when working on notes, > and I'd be prepared to bet that Bruce hasn't either. My advice is to > drop the Changelog file and be sure you describe changes appropriately > in the commit messages. +1. Seems really weird (and unnecessary) to have a changelog for just one small "subsystem", when we don't have it for the others. -- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/
On Sat, Jan 09, 2010 at 11:55:00AM -0500, Tom Lane wrote: > Well, I'm pretty sure that release notes are prepared off of the cvs log > entries. I've never looked at ecpg's Changelog when working on notes, > and I'd be prepared to bet that Bruce hasn't either. My advice is to > drop the Changelog file and be sure you describe changes appropriately > in the commit messages. You definitely get a +1 from me as this file only means additional work that tends to be forgotten. And yes, it does not have any information that the CVS log doesn't have. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL
Tom Lane wrote: > Michael Meskes <meskes@postgresql.org> writes: > > On Fri, Jan 08, 2010 at 03:41:10PM +0100, Stefan Kaltenbrunner wrote: > >> Hmm not sure I find that commit message really helpful - but is it > >> actually of any use to maintain a Changelog file specifically for > >> ECPG? > > > Makes it easier to see what's new in ecpg when doing a new > > release. But I guess we could get all this from the cvs log too. The > > file has been there for a long time. > > Well, I'm pretty sure that release notes are prepared off of the cvs log > entries. I've never looked at ecpg's Changelog when working on notes, > and I'd be prepared to bet that Bruce hasn't either. My advice is to > drop the Changelog file and be sure you describe changes appropriately > in the commit messages. Agreed. I was never aware of an ecpg changelog file. Let's remove it and Michael can make any clarifications to the major releases he wants. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +