Thread: _WIN32_WINNT should be 0x0501 in win32.h

_WIN32_WINNT should be 0x0501 in win32.h

From
Itagaki Takahiro
Date:
We should define _WIN32_WINNT as 0x0500 in src/include/port/win32.h,
but it should be 0x0501 (Windows XP) because IPPROTO_IPV6 will be
defined only if _WIN32_WINNT >= 0x0501 in the recent Micosoft SDKs.

[ws2def.h]
#if(_WIN32_WINNT >= 0x0501)   IPPROTO_IPV6          = 41, // IPv6 header



Index: src/include/port/win32.h
===================================================================
--- src/include/port/win32.h    (head)
+++ src/include/port/win32.h    (work)
@@ -4,7 +4,7 @@#define WIN32_ONLY_COMPILER#endif
-#define _WIN32_WINNT 0x0500
+#define _WIN32_WINNT 0x0501/* * Always build with SSPI support. Keep it as a #define in case * we want a switch to
disableit sometime in the future.
 



Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center



Re: _WIN32_WINNT should be 0x0501 in win32.h

From
Magnus Hagander
Date:
On Monday, September 7, 2009, Itagaki Takahiro
<itagaki.takahiro@oss.ntt.co.jp> wrote:
> We should define _WIN32_WINNT as 0x0500 in src/include/port/win32.h,
> but it should be 0x0501 (Windows XP) because IPPROTO_IPV6 will be
> defined only if _WIN32_WINNT >= 0x0501 in the recent Micosoft SDKs.

Hi!

Have you verified that binaries compiled that way still run on windows
2000? I had checking that on my list before making this change...

/Magnus


-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


Re: _WIN32_WINNT should be 0x0501 in win32.h

From
Itagaki Takahiro
Date:
Magnus Hagander <magnus@hagander.net> wrote:

> Have you verified that binaries compiled that way still run on windows
> 2000? I had checking that on my list before making this change...

No, I don't have Windows 2000.

BTW, there is no Windows 2000 animal in the BuildFarm.
We cannot support win2k at all, no?

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center




Re: _WIN32_WINNT should be 0x0501 in win32.h

From
Magnus Hagander
Date:
On Mon, Sep 7, 2009 at 07:53, Itagaki
Takahiro<itagaki.takahiro@oss.ntt.co.jp> wrote:
>
> Magnus Hagander <magnus@hagander.net> wrote:
>
>> Have you verified that binaries compiled that way still run on windows
>> 2000? I had checking that on my list before making this change...
>
> No, I don't have Windows 2000.
>
> BTW, there is no Windows 2000 animal in the BuildFarm.
> We cannot support win2k at all, no?

I could've sworn we did, but clearly we don't :( I guess that means
we're already in "best effort" mode on it. And to be honest, Microsoft
haven't supported Windows 2000 mainstream since 2005 (they do provided
extended support until next year though).

Anyway, this *should* work on Win2k as well, so I have applied it. We
also have _WIN32_WINNT defined in pg_ctl.c, so I updated that one to
be the same.


-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


Re: _WIN32_WINNT should be 0x0501 in win32.h

From
Magnus Hagander
Date:
On Mon, Sep 7, 2009 at 15:14, Andrew Chernow<ac@esilo.com> wrote:
> Magnus Hagander wrote:
>>
>> On Monday, September 7, 2009, Itagaki Takahiro
>> <itagaki.takahiro@oss.ntt.co.jp> wrote:
>>>
>>> We should define _WIN32_WINNT as 0x0500 in src/include/port/win32.h,
>>> but it should be 0x0501 (Windows XP) because IPPROTO_IPV6 will be
>>> defined only if _WIN32_WINNT >= 0x0501 in the recent Micosoft SDKs.
>>
>> Hi!
>>
>> Have you verified that binaries compiled that way still run on windows
>> 2000? I had checking that on my list before making this change...
>>
>
> Yes they do.  Our current project uses 0x0501.  Windows 2000 is part of our
> build farm and a target platform for that project.  We set WINVER to the
> same value as well.

Thanks, then we should be good to go.

If you're actively working with win2k, any chance you can get us a
buildfarm machine on it? :-)

-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


Re: _WIN32_WINNT should be 0x0501 in win32.h

From
Andrew Chernow
Date:
Magnus Hagander wrote:
> On Monday, September 7, 2009, Itagaki Takahiro
> <itagaki.takahiro@oss.ntt.co.jp> wrote:
>> We should define _WIN32_WINNT as 0x0500 in src/include/port/win32.h,
>> but it should be 0x0501 (Windows XP) because IPPROTO_IPV6 will be
>> defined only if _WIN32_WINNT >= 0x0501 in the recent Micosoft SDKs.
> 
> Hi!
> 
> Have you verified that binaries compiled that way still run on windows
> 2000? I had checking that on my list before making this change...
> 

Yes they do.  Our current project uses 0x0501.  Windows 2000 is part of our 
build farm and a target platform for that project.  We set WINVER to the same 
value as well.

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/


Re: _WIN32_WINNT should be 0x0501 in win32.h

From
Andrew Chernow
Date:
Magnus Hagander wrote:
> On Mon, Sep 7, 2009 at 15:14, Andrew Chernow<ac@esilo.com> wrote:
>> Magnus Hagander wrote:
>>> On Monday, September 7, 2009, Itagaki Takahiro
>>> <itagaki.takahiro@oss.ntt.co.jp> wrote:
>>>> We should define _WIN32_WINNT as 0x0500 in src/include/port/win32.h,
>>>> but it should be 0x0501 (Windows XP) because IPPROTO_IPV6 will be
>>>> defined only if _WIN32_WINNT >= 0x0501 in the recent Micosoft SDKs.
>>> Hi!
>>>
>>> Have you verified that binaries compiled that way still run on windows
>>> 2000? I had checking that on my list before making this change...
>>>
>> Yes they do.  Our current project uses 0x0501.  Windows 2000 is part of our
>> build farm and a target platform for that project.  We set WINVER to the
>> same value as well.
> 
> Thanks, then we should be good to go.
> 
> If you're actively working with win2k, any chance you can get us a
> buildfarm machine on it? :-)
> 

Sure.  I think its an image running on one of our ESXi servers.  I'll look into 
it tomorrow, not supposed to be working today ;)

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/