Thread: CommitFest 2009-07: Remaining Patches
OK, we have the following patches remaining for CommitFest 2009-07... (1) Named and mixed notation for PL. Tom left this one as Waiting on Author because he didn't have much else left to work on, just in case Pavel could rework it in time. I'll move it to Returned with Feedback after tomorrow if it's not resubmitted before then. (2) ECPG dynamic cursor, SQLDA support. I think we're still waiting on Michael Meskes to review this one. (3) query cancel issues in dblink. Joe Conway is planning to review this, but not until this weekend. (4) plpythonu datatype conversion improvements. Peter Eisentraut said that was in progress as of 7/24, and I've seen a few PL/python related commits go by, I think, but not this one, so I guess this one is still waiting on Peter. (5, 6) dependencies for generated header files, autogenerating headers & bki stuff - Tom doesn't seem to think any of this is moving in the right direction, I believe Alvaro likes it, and I think Peter is skeptical as well but I'm not totally sure. It might be nice to have a bit more discussion to figure out what WOULD be a good way to move forward with this project. What is good? What is bad? What is ugly?But the discussion seems to have trailed off so maybeI should just move these to Rejected and give up. (7) Prefix support for synonym dictionary - Just waiting on Oleg to commit this one, I think. (8) Filtering dictionary support and unaccent dictionary - Needs some changes to the docs to handle high-bit characters, but other than that all I think all objections that have been raised have been addressed, so I think this is also ready to commit once the doc issues are addressed. Comments welcome. ...Robert
2009/8/14 Robert Haas <robertmhaas@gmail.com>: > OK, we have the following patches remaining for CommitFest 2009-07... > > (1) Named and mixed notation for PL. Tom left this one as Waiting on > Author because he didn't have much else left to work on, just in case > Pavel could rework it in time. I'll move it to Returned with Feedback > after tomorrow if it's not resubmitted before then. I'll work on it this night. I would to respect some Tom comments. Pavel
On Thu, Aug 13, 2009 at 11:27:54PM -0400, Robert Haas wrote: > (2) ECPG dynamic cursor, SQLDA support. I think we're still waiting > on Michael Meskes to review this one. No. The first part of the patch needs some work and Zoltan is already working on it. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!
On Fri, Aug 14, 2009 at 3:51 AM, Michael Meskes<meskes@postgresql.org> wrote: > On Thu, Aug 13, 2009 at 11:27:54PM -0400, Robert Haas wrote: >> (2) ECPG dynamic cursor, SQLDA support. I think we're still waiting >> on Michael Meskes to review this one. > > No. The first part of the patch needs some work and Zoltan is already working on it. OK, thanks for the update. I'll move it to Returned with Feedback after today. (Of course, if you want to commit it before next CommitFest, you're welcome to do so, but in terms of official CommitFest process it's time to close this one down.) ...Robert
> so I think this is also ready to commit once the doc issues are
> addressed.
Oleg fixed that.
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/
Attachment
Teodor Sigaev escribió: > >so I think this is also ready to commit once the doc issues are > >addressed. > > Oleg fixed that. I think this is good ... as far as I'm concerned you can commit it if you think it's OK. Please make sure you add $PostgreSQL$ tags to all files (at least unaccent.c is missing it) -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support