Thread: "maxretries" option of pg_standby doesn't work as expected

Hi,

> Set the maximum number of times to retry the copy or link command

maxretries option of pg_standby is documented as above, but actually
indicates the maximum number of times to *try* the copy or link command.
So, if "-r 0" is specified, pg_standby always fails.

Attached is the patch which adjusted the code so that maxretries actually
indicates the number of retry.

Comments?

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Fujii Masao <masao.fujii@gmail.com> writes:
>> Set the maximum number of times to retry the copy or link command

> maxretries option of pg_standby is documented as above, but actually
> indicates the maximum number of times to *try* the copy or link command.
> So, if "-r 0" is specified, pg_standby always fails.

> Attached is the patch which adjusted the code so that maxretries actually
> indicates the number of retry.

Looks correct to me; applied to HEAD and 8.3.  Thanks!
        regards, tom lane