Thread: Wrong comment in ReadControlFile

Wrong comment in ReadControlFile

From
Zdenek Kotala
Date:
When we have now collation per database I think following comment is
useless:

* (2) this code is executed in the postmaster, so the setlocale() will
* propagate to forked backends, which aren't going to read this file for
* themselves.    (These locale settings are considered critical
* compatibility items because they can affect sort order of indexes.)


Patch attached.

        Zdenek

Attachment

Re: Wrong comment in ReadControlFile

From
Bruce Momjian
Date:
Zdenek Kotala wrote:
> When we have now collation per database I think following comment is
> useless:
> 
> * (2) this code is executed in the postmaster, so the setlocale() will
> * propagate to forked backends, which aren't going to read this file for
> * themselves.    (These locale settings are considered critical
> * compatibility items because they can affect sort order of indexes.)
> 
> 
> Patch attached.

Heikki has applied your patch.  Thanks.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


Re: Wrong comment in ReadControlFile

From
Heikki Linnakangas
Date:
Zdenek Kotala wrote:
> When we have now collation per database I think following comment is
> useless:
> 
> * (2) this code is executed in the postmaster, so the setlocale() will
> * propagate to forked backends, which aren't going to read this file for
> * themselves.    (These locale settings are considered critical
> * compatibility items because they can affect sort order of indexes.)
> 
> 
> Patch attached.

Thanks, committed.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com