Thread: [patch] Reformat permissions in \l+ (like \z does)

[patch] Reformat permissions in \l+ (like \z does)

From
Andreas 'ads' Scherbaum
Date:
Hello,

the march 2008 commitfest added a patch[1] with extended information for
\l+. The may 2008 commitfest added a patch[2] which reformats the
permission output in \z. I like the new output in \z, but the \l+
output is still missing this feature. The attached patch solves this
problem.



Kind regards


1:
http://archives.postgresql.org/message-id/488C2FE3-A6C7-4CFA-BD3C-F0588DA81F2E@tcpd.net

2:
http://archives.postgresql.org/message-id/37ed240d0804170921h7a6b92fev65aeb99f658f8f21@mail.gmail.com

--
                Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors

Attachment

Re: [patch] Reformat permissions in \l+ (like \z does)

From
Tom Lane
Date:
"Andreas 'ads' Scherbaum" <adsmail@wars-nicht.de> writes:
> the march 2008 commitfest added a patch[1] with extended information for
> \l+. The may 2008 commitfest added a patch[2] which reformats the
> permission output in \z. I like the new output in \z, but the \l+
> output is still missing this feature. The attached patch solves this
> problem.

If we're going to do this, shouldn't it happen uniformly for *all*
ACL displays in describe.c?
        regards, tom lane


Re: [patch] Reformat permissions in \l+ (like \z does)

From
Andreas 'ads' Scherbaum
Date:
On Sun, 28 Dec 2008 18:19:48 -0500 Tom Lane wrote:

> "Andreas 'ads' Scherbaum" <adsmail@wars-nicht.de> writes:
> > the march 2008 commitfest added a patch[1] with extended information for
> > \l+. The may 2008 commitfest added a patch[2] which reformats the
> > permission output in \z. I like the new output in \z, but the \l+
> > output is still missing this feature. The attached patch solves this
> > problem.
> 
> If we're going to do this, shouldn't it happen uniformly for *all*
> ACL displays in describe.c?

Makes sense, imho.
I just stumbled over this one by checking the list of new patches for
8.4.

Other opinions?


Kind regards

--             Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors


Re: [patch] Reformat permissions in \l+ (like \z does)

From
Tom Lane
Date:
"Andreas 'ads' Scherbaum" <adsmail@wars-nicht.de> writes:
> On Sun, 28 Dec 2008 18:19:48 -0500 Tom Lane wrote:
>> If we're going to do this, shouldn't it happen uniformly for *all*
>> ACL displays in describe.c?

> Makes sense, imho.

Done.
        regards, tom lane


Re: [patch] Reformat permissions in \l+ (like \z does)

From
Andreas 'ads' Scherbaum
Date:
On Wed, 31 Dec 2008 13:08:20 -0500 Tom Lane wrote:

> "Andreas 'ads' Scherbaum" <adsmail@wars-nicht.de> writes:
> > On Sun, 28 Dec 2008 18:19:48 -0500 Tom Lane wrote:
> >> If we're going to do this, shouldn't it happen uniformly for *all*
> >> ACL displays in describe.c?
> 
> > Makes sense, imho.
> 
> Done.

Oh, thanks. The updated patch was on my todo.


Kind regards

--             Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors