Postgres Pro
Downloads
Home   >   mailing lists

Thread: libpq events update

libpq events update

From
Andrew Chernow
Date:
I would like to remove the PQpassThroughData and PQresultPassThroughData 
functions.    The passThrough pointer should be added as a 3rd argument 
to the PGEventProc:

typedef int (*PGEventProc)(PGEventId evtId, void *evtInfo,  void *passThrough);

Having a public accessor function for the passThrough. doesn't seem 
helpful.  Its purpose is to be available to the eventproc, which doesn't 
require a public function.

I think it got confused with the instanceData feature, which has nothing 
to do with the event system and requires public functions.  libpqtypes 
happens to use the instanceData functions within its eventproc, but this 
is not a requirement.

All those who oppose any of the above, speak now or forever hold your 
peace.  An updated patch with full sgml documentation is coming.

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

Re: libpq events update

From
Andrew Chernow
Date:
Andrew Chernow wrote:
> 
> I think it got confused with the instanceData feature, which has nothing 
> to do with the event system and requires public functions.  libpqtypes 
> happens to use the instanceData functions within its eventproc, but this 
> is not a requirement.
> 

I forgot to mention that the instanceData functions should be moved from 
libpq-events.h to libpq-fe.h because they are not part of the event 
system.  I plan on making this change as well, so let me know if you 
hate it.

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

Re: libpq events update

From
"Merlin Moncure"
Date:
On Fri, Sep 5, 2008 at 9:54 AM, Andrew Chernow <ac@esilo.com> wrote:
> Andrew Chernow wrote:
>>
>> I think it got confused with the instanceData feature, which has nothing
>> to do with the event system and requires public functions.  libpqtypes
>> happens to use the instanceData functions within its eventproc, but this is
>> not a requirement.
>>
>
> I forgot to mention that the instanceData functions should be moved from
> libpq-events.h to libpq-fe.h because they are not part of the event system.
>  I plan on making this change as well, so let me know if you hate it.


An updated patch with docs and the above change is on -patches.
Should we have sent that here?

merlin