Thread: September Commit Fest coming soon!
Folks, The september commit fest starts in one week. The goal, this time, is to start reviewing on day 1 of the commit fest and not spend the first 3 days collecting extra patches. So if your patch isn't on the list *on* September 1, it may get pushed into November. So get it on the list now! http://wiki.postgresql.org/wiki/CommitFest:2008-09 Second, I need to know who's available for round-robin reviewing for this commitfest (September 1-15). If you volunteer, you'll be assigned a patch to review on September 4 from the list of unclaimed patches, and will be expected to review it within 5 days. And then hopefully be assigned a second one. Please, we really need help reviewing, and this is a good way to gain experience. --Josh "Commitfest Mom" Berkus
On Tue, Aug 26, 2008 at 1:28 PM, Josh Berkus <josh@agliodbs.com> wrote: > > Second, I need to know who's available for round-robin reviewing for this > commitfest (September 1-15). let's make a try... count with me for round-robin reviewing... -- regards, Jaime Casanova Soporte y capacitación de PostgreSQL Asesoría y desarrollo de sistemas Guayaquil - Ecuador Cel. (593) 87171157
Hi, 2008/8/27 Josh Berkus <josh@agliodbs.com>: > Folks, > > The september commit fest starts in one week. The goal, this time, is to > start reviewing on day 1 of the commit fest and not spend the first 3 days > collecting extra patches. > > So if your patch isn't on the list *on* September 1, it may get pushed into > November. So get it on the list now! > > http://wiki.postgresql.org/wiki/CommitFest:2008-09 > For the git hosted projects, should we send in the latest patch file to this list? Or just keep it static and reviewers will extract diff from there? -- Hitoshi Harada
At 2008-08-28 20:09:21 +0900, umi.tanuki@gmail.com wrote: > > For the git hosted projects, should we send in the latest patch file > to this list? Yes, please do that. -- ams
Abhijit Menon-Sen <ams@oryx.com> writes:
> At 2008-08-28 20:09:21 +0900, umi.tanuki@gmail.com wrote:
>> For the git hosted projects, should we send in the latest patch file
>> to this list?
> Yes, please do that.
Yes. You should *not* assume that reviewers are going to look at the
git repository.
regards, tom lane
Gregory Stark <stark@enterprisedb.com> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> Yes. You should *not* assume that reviewers are going to look at the
>> git repository.
> However when a committer is actually looking to commit the code he'll want to
> be sure he has the most recent snapshot including any later changes that might
> not have warranted an email.
I'm going to state for the record that I have no intention of digging
around in unofficial repositories for unsubmitted changes (that might
or might not have been intended to go in anyway). If you don't like
what I commit, send a delta patch.
regards, tom lane
Tom Lane <tgl@sss.pgh.pa.us> writes: > Abhijit Menon-Sen <ams@oryx.com> writes: >> At 2008-08-28 20:09:21 +0900, umi.tanuki@gmail.com wrote: >>> For the git hosted projects, should we send in the latest patch file >>> to this list? > >> Yes, please do that. > > Yes. You should *not* assume that reviewers are going to look at the > git repository. I think we should include both. They serve two different purposes. The GIT repository might disappear some day or be inaccessible for some users. Also you might be asking for commentary on specific questions about that specific snapshot. However when a committer is actually looking to commit the code he'll want to be sure he has the most recent snapshot including any later changes that might not have warranted an email. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's RemoteDBA services!