Thread: port/thread.c and pthreads

port/thread.c and pthreads

From
Magnus Hagander
Date:
port/thread.c includes the pthreads header files, and contains a bunch
of comments about pthreads - but there seems to be no code related to
pthreads at all in the file. Am I missing something completely here? ;-)

//Magnus


Re: port/thread.c and pthreads

From
Bruce Momjian
Date:
Magnus Hagander wrote:
> port/thread.c includes the pthreads header files, and contains a bunch
> of comments about pthreads - but there seems to be no code related to
> pthreads at all in the file. Am I missing something completely here? ;-)

Uh, those files are thread-safe/reentrant versions of libc functions.  I
don't think they need the pthread.h includes.  You want to try removing
those includes and see how the buildfarm behaves?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


Re: port/thread.c and pthreads

From
Magnus Hagander
Date:
Bruce Momjian wrote:
> Magnus Hagander wrote:
> > port/thread.c includes the pthreads header files, and contains a
> > bunch of comments about pthreads - but there seems to be no code
> > related to pthreads at all in the file. Am I missing something
> > completely here? ;-)
> 
> Uh, those files are thread-safe/reentrant versions of libc
> functions.  I don't think they need the pthread.h includes.  You want
> to try removing those includes and see how the buildfarm behaves?

Done, let's see what happens...

//Magnus


Re: port/thread.c and pthreads

From
Alvaro Herrera
Date:
Magnus Hagander wrote:
> Bruce Momjian wrote:

> > Uh, those files are thread-safe/reentrant versions of libc
> > functions.  I don't think they need the pthread.h includes.  You want
> > to try removing those includes and see how the buildfarm behaves?
> 
> Done, let's see what happens...

Apparently the world failed to end.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


Re: port/thread.c and pthreads

From
Magnus Hagander
Date:
Alvaro Herrera wrote:
> Magnus Hagander wrote:
> > Bruce Momjian wrote:
> 
> > > Uh, those files are thread-safe/reentrant versions of libc
> > > functions.  I don't think they need the pthread.h includes.  You
> > > want to try removing those includes and see how the buildfarm
> > > behaves?
> > 
> > Done, let's see what happens...
> 
> Apparently the world failed to end.

Almost a bit disappointing ;-)

//Magnus


Re: port/thread.c and pthreads

From
Bruce Momjian
Date:
Magnus Hagander wrote:
> Alvaro Herrera wrote:
> > Magnus Hagander wrote:
> > > Bruce Momjian wrote:
> > 
> > > > Uh, those files are thread-safe/reentrant versions of libc
> > > > functions.  I don't think they need the pthread.h includes.  You
> > > > want to try removing those includes and see how the buildfarm
> > > > behaves?
> > > 
> > > Done, let's see what happens...
> > 
> > Apparently the world failed to end.
> 
> Almost a bit disappointing ;-)

:-)  All that threading stuff was done before we had a buildfarm so
everything was a big guess.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +