Thread: Re: [BUGS] possible bug windows setup

On Wed, Feb 06, 2008 at 02:59:31PM +0100, Gevik Babakhani wrote:
> I might be very wrong, but when I try to install 8.3 on Windows with NLS
> options selected, no share/locale files are installed. could someone please
> test or confirm this?

Yes, it's broken. It seems the change in Install.pm rev 1.20 to use
File::Find instead of external dir broke this, and was never tested at all
:-(

I know I build without NLS enabled, and it seems so does everybody else who
regularly builds the msvc stuff.

There is no testing at all of the NLS stuff in the regression tests.
Perhaps it would be a good idea to do that? Could be somethign as simple as
launching psql in a way tha tgenerates a syntax error and make sure i
matches a proper translation?


(and yes, I'm working on a patch for the actual issue)

//Magnus

Magnus Hagander wrote:
> On Wed, Feb 06, 2008 at 02:59:31PM +0100, Gevik Babakhani wrote:
>   
>> I might be very wrong, but when I try to install 8.3 on Windows with NLS
>> options selected, no share/locale files are installed. could someone please
>> test or confirm this?
>>     
>
> Yes, it's broken. It seems the change in Install.pm rev 1.20 to use
> File::Find instead of external dir broke this, and was never tested at all
> :-(
>
> I know I build without NLS enabled, and it seems so does everybody else who
> regularly builds the msvc stuff.
>
> There is no testing at all of the NLS stuff in the regression tests.
> Perhaps it would be a good idea to do that? Could be somethign as simple as
> launching psql in a way tha tgenerates a syntax error and make sure i
> matches a proper translation?
>
>
> (and yes, I'm working on a patch for the actual issue)
>
>
>   

Oops, My bad!

I think if we just change the forward slashes to backslashes at the top[ 
of that loop it should work, but haven't had time to test.

cheers

andrew

On Thu, Feb 07, 2008 at 06:12:17AM -0500, Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
> >On Wed, Feb 06, 2008 at 02:59:31PM +0100, Gevik Babakhani wrote:
> >
> >>I might be very wrong, but when I try to install 8.3 on Windows with NLS
> >>options selected, no share/locale files are installed. could someone
> >>please
> >>test or confirm this?
> >>
> >
> >Yes, it's broken. It seems the change in Install.pm rev 1.20 to use
> >File::Find instead of external dir broke this, and was never tested at all
> >:-(
> >
> >I know I build without NLS enabled, and it seems so does everybody else who
> >regularly builds the msvc stuff.
> >
> >There is no testing at all of the NLS stuff in the regression tests.
> >Perhaps it would be a good idea to do that? Could be somethign as simple as
> >launching psql in a way tha tgenerates a syntax error and make sure i
> >matches a proper translation?
> >
> >
> >(and yes, I'm working on a patch for the actual issue)
> >
> >
> >
>
> Oops, My bad!
>
> I think if we just change the forward slashes to backslashes at the top[
> of that loop it should work, but haven't had time to test.

No, it'sa  bit more than that, but that's one of the changes :)

I have a patch working for me, I've sent it over to Gevik for testing in
his environment. Attached here if somebody else wants to play.

//Magnus

Magnus Hagander wrote:
>
> I have a patch working for me, I've sent it over to Gevik for testing in
> his environment. Attached here if somebody else wants to play.
>
>   

Looks OK.

cheers

andrew