Thread: tsearch2 documentation done
I am now satisified with the tsearch2 documentation in SGML and have marked the item as complete for 8.3. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
On Thu, 13 Sep 2007, Bruce Momjian wrote: > I am now satisified with the tsearch2 documentation in SGML and have > marked the item as complete for 8.3. what's about examples ? They certainly need updating. For example, http://momjian.us/main/writings/pgsql/sgml/textsearch-rule-dictionary-example.html need to change #include "utils/ts_locale.h" #include "utils/ts_public.h" #include "utils/ts_utils.h" to #include "tsearch/ts_locale.h" #include "tsearch/ts_public.h" #include "tsearch/ts_utils.h" Regards, Oleg _____________________________________________________________ Oleg Bartunov, Research Scientist, Head of AstroNet (www.astronet.ru), Sternberg Astronomical Institute, Moscow University, Russia Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(495)939-16-83, +007(495)939-23-83
Oleg Bartunov <oleg@sai.msu.su> writes: > On Thu, 13 Sep 2007, Bruce Momjian wrote: >> I am now satisified with the tsearch2 documentation in SGML and have >> marked the item as complete for 8.3. > what's about examples ? They certainly need updating. Bruce might be satisfied, but I'm not ... feel free to hack away on the docs. > For example, http://momjian.us/main/writings/pgsql/sgml/textsearch-rule-dictionary-example.html > need to change I'd much prefer to see the C-code examples pushed out to contrib modules. There is no way we can test or maintain things that are embedded in SGML examples. regards, tom lane
Oleg Bartunov wrote: > On Thu, 13 Sep 2007, Bruce Momjian wrote: > > > I am now satisified with the tsearch2 documentation in SGML and have > > marked the item as complete for 8.3. > > what's about examples ? They certainly need updating. > For example, http://momjian.us/main/writings/pgsql/sgml/textsearch-rule-dictionary-example.html > need to change > > #include "utils/ts_locale.h" > #include "utils/ts_public.h" > #include "utils/ts_utils.h" > > to > > #include "tsearch/ts_locale.h" > #include "tsearch/ts_public.h" > #include "tsearch/ts_utils.h" Updated. Thanks. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Tom Lane wrote: > Oleg Bartunov <oleg@sai.msu.su> writes: > > On Thu, 13 Sep 2007, Bruce Momjian wrote: > >> I am now satisified with the tsearch2 documentation in SGML and have > >> marked the item as complete for 8.3. > > > what's about examples ? They certainly need updating. > > Bruce might be satisfied, but I'm not ... feel free to hack away on the docs. Yes, it still needs more work, but it is done enough that the feature is ready for beta. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
On Fri, 14 Sep 2007, Tom Lane wrote: > Oleg Bartunov <oleg@sai.msu.su> writes: >> On Thu, 13 Sep 2007, Bruce Momjian wrote: >>> I am now satisified with the tsearch2 documentation in SGML and have >>> marked the item as complete for 8.3. > >> what's about examples ? They certainly need updating. > > Bruce might be satisfied, but I'm not ... feel free to hack away on the docs. > >> For example, http://momjian.us/main/writings/pgsql/sgml/textsearch-rule-dictionary-example.html >> need to change > > I'd much prefer to see the C-code examples pushed out to contrib > modules. There is no way we can test or maintain things that are > embedded in SGML examples. What if we prepare contrib/ts_pack with all examples from documentation and couple of useful dictionaries ? > > regards, tom lane > Regards, Oleg _____________________________________________________________ Oleg Bartunov, Research Scientist, Head of AstroNet (www.astronet.ru), Sternberg Astronomical Institute, Moscow University, Russia Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(495)939-16-83, +007(495)939-23-83
Oleg Bartunov <oleg@sai.msu.su> writes:
> What if we prepare contrib/ts_pack with all examples from documentation
> and couple of useful dictionaries ?
OK by me...
regards, tom lane