Thread: Should we bump libpq major version for 8.3?
As of today there are two new functions exported by libpq.so since 8.2 (lo_truncate and PQconnectionUsedPassword). Currently, libpq/Makefile sets the major.minor shlib version to 5.1 as compared to 5.0 in PG 8.2. Should it be 6.0? I seem to recall people chastizing us for not bumping the major version if there were any ABI changes at all, forward-compatible or not. regards, tom lane
* Tom Lane (tgl@sss.pgh.pa.us) wrote: > As of today there are two new functions exported by libpq.so since > 8.2 (lo_truncate and PQconnectionUsedPassword). Currently, > libpq/Makefile sets the major.minor shlib version to 5.1 as compared > to 5.0 in PG 8.2. Should it be 6.0? I seem to recall people > chastizing us for not bumping the major version if there were any > ABI changes at all, forward-compatible or not. No, it should be 5.1 (we havn't released a 5.1 at all yet, have we?). Adding functions is a minor shlib bump and should *not* change the SONAME (which includes the major here, objdump -p libpq.so.5.0). Thanks, Stephen
Stephen Frost wrote: -- Start of PGP signed section. > * Tom Lane (tgl@sss.pgh.pa.us) wrote: > > As of today there are two new functions exported by libpq.so since > > 8.2 (lo_truncate and PQconnectionUsedPassword). Currently, > > libpq/Makefile sets the major.minor shlib version to 5.1 as compared > > to 5.0 in PG 8.2. Should it be 6.0? I seem to recall people > > chastizing us for not bumping the major version if there were any > > ABI changes at all, forward-compatible or not. > > No, it should be 5.1 (we havn't released a 5.1 at all yet, have we?). > Adding functions is a minor shlib bump and should *not* change the > SONAME (which includes the major here, objdump -p libpq.so.5.0). Agreed. src/tools/RELEASE_CHANGES says only a minor bump is needed, and I already did that for 8.3. We are OK. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +