Thread: Re: [PATCHES] this patch correct upper and lower case for translated month's and day's names
Re: [PATCHES] this patch correct upper and lower case for translated month's and day's names
From
Tom Lane
Date:
"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> this patch correct bug in to_char function with incorrect uppercased month's
> or day's name.
I still think this coding is unsafe in the case where the modified
string is longer than the original. Also, could we please not duplicate
such a large chunk of code between here and oracle_compat.c?
regards, tom lane
Re: [PATCHES] this patch correct upper and lower case for translated month's and
From
"Pavel Stehule"
Date:
> >"Pavel Stehule" <pavel.stehule@hotmail.com> writes: > > this patch correct bug in to_char function with incorrect uppercased >month's > > or day's name. > >I still think this coding is unsafe in the case where the modified >string is longer than the original. Also, could we please not duplicate >such a large chunk of code between here and oracle_compat.c? > > regards, tom lane I hope so not. It's safe if argument "inout" is pointer on safety long buffer. Propably this function's can sit in somewhere else, but I expect so will for text and str, because without controls has only 2 lines of code. This patch is minimalistic, without others non neccesery changes. Regards Pavel Stehule _________________________________________________________________ Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci. http://messenger.msn.cz/