Thread: Re: [PATCHES] [PERFORM] Direct I/O issues

Bruce Momjian <bruce@momjian.us> writes:
> Not sure if people want this for 8.2.  I think we can modify
> test_fsync.c anytime but the movement of the defines into an include
> file is a backend code change.

I think fooling with this on the day before RC1 is an unreasonable risk ...
and I disapprove of moving this code into a widely-used include file
like xlog.h, too.

            regards, tom lane

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Not sure if people want this for 8.2.  I think we can modify
> > test_fsync.c anytime but the movement of the defines into an include
> > file is a backend code change.
>
> I think fooling with this on the day before RC1 is an unreasonable risk ...
> and I disapprove of moving this code into a widely-used include file
> like xlog.h, too.

OK, you want a separate include or xlog_internal.h?  And should I put in
just the test_fsync changes next week so at least we are closer to
having it work for 8.2?

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +