Thread: Re: [PATCHES] Contrib Makefiles

"Magnus Hagander" <mha@sollentuna.net> writes:
> A couple of the Makefiles in contrib don't define OBJS= as standard,
> instead they define SRCS= and then a makefile rule for OBJS= that does a
> replacement on that.

> Is there any actual reason for that?

Can't see one.

> If not, could the attached patch
> please be applied to make them all look the same.

Done, but what about pgcrypto?  You may not have a choice but to have a
special case for that one, though, seeing it builds its list on the fly.

            regards, tom lane

> > A couple of the Makefiles in contrib don't define OBJS= as
> standard,
> > instead they define SRCS= and then a makefile rule for
> OBJS= that does
> > a replacement on that.
>
> > Is there any actual reason for that?
>
> Can't see one.

Ok. Thanks.


> > If not, could the attached patch
> > please be applied to make them all look the same.
>
> Done, but what about pgcrypto?  You may not have a choice but
> to have a special case for that one, though, seeing it builds
> its list on the fly.

Yeah, it's currently on my list of "not yet done" parts. I'm also
thinking there's a very large probability that I'll have to special-case
it.

//Magnus