Thread: set_pglocale_pgservice considered harmful

set_pglocale_pgservice considered harmful

From
Tom Lane
Date:
Why in the world is set_pglocale_pgservice() located in src/port/path.c?

I was just trying to find out why ecpg is failing on the Darwin
buildfarm members since I modified the arrangements for pulling in extra
libraries for AIX.  The answer is that ecpglib needs path.c for
last_dir_separator(), and path.c contains set_pglocale_pgservice(),
which pulls in both exec.c and bindtextdomain/textdomain/gettext.
IOW libintl gets pulled into ecpglib links for no reason whatsoever
--- it certainly isn't being used by ecpglib itself.

I think set_pglocale_pgservice should either be moved to exec.c or put
into its own separate src/port/ file.  Comments?
        regards, tom lane