Thread: Re: [PATCHES] Use of backslash in tsearch2

Re: [PATCHES] Use of backslash in tsearch2

From

Teodor Sigaev

Date:

22 August 2006, 07:50:34

>> Teodor, are the new attached regression results correct?  If so, I will
>> apply the patch and update the expected file.

Patch isn't full, simple test (values are took from regression.diffs):
# create table tt (tv tsvector, tq tsquery);
# insert into tt values (E'''1 \\''2''', NULL);
# insert into tt values (E'''1 \\''2''3', NULL);
# insert into tt values ( E'''1 \\''2'' 3', NULL);
# insert into tt values ( E'''1 \\''2'' '' 3'' 4 ', NULL);
# insert into tt values ( NULL, E'''1 \\''2''');
# insert into tt values ( NULL, E'''1 \\''2''');
# insert into tt values ( NULL, E'1&(''2''&('' 4''&(\\|5 | ''6 \\'' !|&'')))');
# insert into tt values ( NULL, E'1&(''2''&('' 4''&(\\|5 | ''6 \\'' !|&'')))');


and try dump table and restore:
ERROR:  syntax error
CONTEXT:  COPY tt, line 5, column tq: "'1 ''2'"

PS I'm not subscribed to -patches, so I post to -hackers

--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Re: [PATCHES] Use of backslash in tsearch2

From

Teodor Sigaev

Date:

23 August 2006, 12:08:36

> Patch isn't full, simple test (values are took from regression.diffs):
> and try dump table and restore:
> ERROR:  syntax error
> CONTEXT:  COPY tt, line 5, column tq: "'1 ''2'"
>

Attached cumulative patch fixes problem, but I have some doubts, is it really
needed?


--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Re: [PATCHES] Use of backslash in tsearch2

From

Bruce Momjian

Date:

02 September 2006, 22:05:03

Thanks.  Yes, it is need for two reasons.  In 8.2 you can set
standard_conforming_strings to on, meaning \' is really treated as \ and
', and because some encodings now can't support \' for security reasons,
though I don't think tsearch2 supports those multibyte encodings.
Anyway, applied to 8.2 only, not backpatched.  Thanks.

---------------------------------------------------------------------------

Teodor Sigaev wrote:
> > Patch isn't full, simple test (values are took from regression.diffs):
> > and try dump table and restore:
> > ERROR:  syntax error
> > CONTEXT:  COPY tt, line 5, column tq: "'1 ''2'"
> >
>
> Attached cumulative patch fixes problem, but I have some doubts, is it really
> needed?
>
>
> --
> Teodor Sigaev                                   E-mail: teodor@sigaev.ru
>                                                     WWW: http://www.sigaev.ru/

[ application/x-tar is not supported, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +