Thread: Re: [PATCHES] Use of backslash in tsearch2

Re: [PATCHES] Use of backslash in tsearch2

From
Tom Lane
Date:
Bruce Momjian <bruce@momjian.us> writes:
> As part of the move to support standard-conforming strings and treat
> backslash literally, I reviewed the tsearch2 code and found two place
> that seemed to use \' rather than '', and generated the attached patch.

I thought we had decided that that code should not be changed.  It has
nothing to do with SQL literals, and changing it will create unnecessary
backwards-compatibility problems.

            regards, tom lane

Re: [PATCHES] Use of backslash in tsearch2

From
Bruce Momjian
Date:
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > As part of the move to support standard-conforming strings and treat
> > backslash literally, I reviewed the tsearch2 code and found two place
> > that seemed to use \' rather than '', and generated the attached patch.
>
> I thought we had decided that that code should not be changed.  It has
> nothing to do with SQL literals, and changing it will create unnecessary
> backwards-compatibility problems.

I don't remember any comment regarding that.  I think it does relate to
SQL literals because it is creating a literal inside a literal. Also, at
the time this was a core-only discussion and I am hoping from a comment
from the tsearch2 folks.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +