Thread: Re: [PATCHES] plpython improvements

Anyone in a position to review the pending plpython patch?
http://archives.postgresql.org/pgsql-patches/2006-08/msg00151.php

After that little fiasco with plperl I'm disinclined to apply anything
without review by somebody who's pretty familiar with the PL in
question ... and Python's not my language.
        regards, tom lane

On Fri, Aug 18, 2006 at 04:27:23PM -0400, Tom Lane wrote:
> Anyone in a position to review the pending plpython patch?
> http://archives.postgresql.org/pgsql-patches/2006-08/msg00151.php

In several places the code does this:
   so = PyObject_Str(value);   valuestr = PyString_AsString(so);

We've previously learned that calling PyString_AsString() without
checking the return value of PyObject_Str() can result in a
segmentation fault.

http://archives.postgresql.org/pgsql-committers/2005-07/msg00233.php

I haven't examined the current patch closely enough to know whether
PyObject_Str() can possibly return NULL, but several occurrences
of the above code snippet caught my eye because we had dealt with
it before.

-- 
Michael Fuhr

Tom Lane wrote:
> Anyone in a position to review the pending plpython patch?
> http://archives.postgresql.org/pgsql-patches/2006-08/msg00151.php
>
> After that little fiasco with plperl I'm disinclined to apply anything
> without review by somebody who's pretty familiar with the PL in
> question ... and Python's not my language.
>
>

does it have docs?

cheers

andrew