Thread: Updatable views

Updatable views

From
Alvaro Herrera
Date:
Hi,

Is anybody working on Bernd's updatable views patch?  Right now I'm
having a look at it -- mainly fixing some cosmetic issues right now,
intending to eventually do an actual code review.

I'll post an updated patch at some point -- if someone wants to have a
look or do some intensive review, just ask and I'll send whatever I
have.  

-- 
Alvaro Herrera                                http://www.PlanetPostgreSQL.org
"Digital and video cameras have this adjustment and film cameras don't for the
same reason dogs and cats lick themselves: because they can."   (Ken Rockwell)


Re: Updatable views

From
Bruce Momjian
Date:
Alvaro Herrera wrote:
> Hi,
> 
> Is anybody working on Bernd's updatable views patch?  Right now I'm
> having a look at it -- mainly fixing some cosmetic issues right now,
> intending to eventually do an actual code review.
> 
> I'll post an updated patch at some point -- if someone wants to have a
> look or do some intensive review, just ask and I'll send whatever I
> have.  

Great.  You have been a big help in the past in reviewing patches during
feature freeze.  Also Neil used to help too.

I have talked to Tom and he knows the outstanding patches that are out
there.  I am going through the less visible ones and hope to put up an
outstanding patch list in the next week, but if you are going to be
involved too, I will try to do it sooner.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


Re: Updatable views

From
Tom Lane
Date:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Is anybody working on Bernd's updatable views patch?  Right now I'm
> having a look at it -- mainly fixing some cosmetic issues right now,
> intending to eventually do an actual code review.

Great --- it's on my to-do list but I'm happy to have more eyeballs
on it.  My advice is to look first for showstoppers: is there anything
fundamentally wrong/broken?  With something like this it's not at all
unlikely that the basic approach doesn't really work.

> I'll post an updated patch at some point -- if someone wants to have a
> look or do some intensive review, just ask and I'll send whatever I
> have.  

No hurry from me; I've got a lot of other things to look at too,
so I'll just drop this one back towards the end of the list.
        regards, tom lane