Thread: Re: [COMMITTERS] pgsql: Move "#define inline __inline" from port/win32.h to c.h because

momjian@postgresql.org (Bruce Momjian) writes:
> Move "#define inline __inline" from port/win32.h to c.h because Win32
> interface builds like libpq need it.

Huh?  port/win32.h is #included by c.h (as pg_config_os.h), no?
I don't see why it's necessary to clutter c.h with this
platform-specific hack, when we have a perfectly fine mechanism
for not doing that.

            regards, tom lane

Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian) writes:
> > Move "#define inline __inline" from port/win32.h to c.h because Win32
> > interface builds like libpq need it.
>
> Huh?  port/win32.h is #included by c.h (as pg_config_os.h), no?
> I don't see why it's necessary to clutter c.h with this
> platform-specific hack, when we have a perfectly fine mechanism
> for not doing that.

Right. I was wrong and the problem was that the inline define was
missing in the win32.h.  That has been fixed in a later commit.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +