Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT

Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT

From
Bruce Momjian
Date:
David Fetter wrote:
> On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Done:
> > 
> >         o -Display IN, INOUT, and OUT parameters in \df
> 
> Oops!  Should I change the patch to say IN when it's an IN parameter?
> Right now, it stays silent.

[ Moved to hackers.]  No idea.  Comments?

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +

Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT,

From
Andrew Dunstan
Date:
Bruce Momjian wrote:
> David Fetter wrote:
>   
>> On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:
>>     
>>> Log Message:
>>> -----------
>>> Done:
>>>
>>>         o -Display IN, INOUT, and OUT parameters in \df
>>>       
>> Oops!  Should I change the patch to say IN when it's an IN parameter?
>> Right now, it stays silent.
>>     
>
> [ Moved to hackers.]  No idea.  Comments?
>
>   
Actually, I'd be inclined to put IN if there are INOUT or OUT 
parameters, and nothing if they are all IN parameters, but I realise 
this might seem inconsistent.

cheers

andrew

Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df

From
David Fetter
Date:
On Tue, Jul 18, 2006 at 06:07:01PM -0400, Bruce Momjian wrote:
> David Fetter wrote:
> > On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Done:
> > > 
> > >         o -Display IN, INOUT, and OUT parameters in \df
> > 
> > Oops!  Should I change the patch to say IN when it's an IN
> > parameter?  Right now, it stays silent.
> 
> [ Moved to hackers.]  No idea.  Comments?

I'm thinking "no."  Parameters by default are unnamed IN parameters,
so I exposed and marked things which differed from that. :)

Cheers,
D
-- 
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778        AIM: dfetter666                             Skype: davidfetter

Remember to vote!

Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df

From
Tom Lane
Date:
David Fetter <david@fetter.org> writes:
> On Tue, Jul 18, 2006 at 06:07:01PM -0400, Bruce Momjian wrote:
>> [ Moved to hackers.]  No idea.  Comments?

> I'm thinking "no."  Parameters by default are unnamed IN parameters,
> so I exposed and marked things which differed from that. :)

I agree; the patch already makes \df more noisy than some would wish.
        regards, tom lane