Thread: TODO: Mark change-on-restart-only values in postgresql.conf
I would like to implement "Mark change-on-restart-only values in postgresql.conf" item. Anybody works on this? Does it mean add extra comment to postgresql.conf for variable which has PG_POSTMASTER context? Zdenek
Zdenek, > I would like to implement "Mark change-on-restart-only values in > postgresql.conf" item. Anybody works on this? Does it mean add extra > comment to postgresql.conf for variable which has PG_POSTMASTER context? Somehow I thought you'd already submitted a patch? -- --Josh Josh Berkus PostgreSQL @ Sun San Francisco
Josh Berkus wrote:
> Zdenek,
>
>> I would like to implement "Mark change-on-restart-only values in
>> postgresql.conf" item. Anybody works on this? Does it mean add extra
>> comment to postgresql.conf for variable which has PG_POSTMASTER context?
>
> Somehow I thought you'd already submitted a patch?
>
I sent patch for relatively related problem when somebody commenting out
item in the configuration file. This item is look like easy, but I
surprise that this item does not have % prefix. The question is if it is
only about adding extra comments to postgresql.conf file.
Zdenek
On Jul 17, 2006, at 2:48 PM, Zdenek Kotala wrote: > Josh Berkus wrote: >> Zdenek, >>> I would like to implement "Mark change-on-restart-only values in >>> postgresql.conf" item. Anybody works on this? Does it mean add extra >>> comment to postgresql.conf for variable which has PG_POSTMASTER >>> context? >> Somehow I thought you'd already submitted a patch? > I sent patch for relatively related problem when somebody > commenting out item in the configuration file. This item is look > like easy, but I surprise that this item does not have % prefix. > The question is if it is only about adding extra comments to > postgresql.conf file. If memory serves, we also wanted to have the postmaster log a warning if it reloaded postgresql.conf and found values that had changed but wouldn't take effect until restart. So presumably the postmaster would have to keep an in-memory copy of the parsed postgresql.conf and compare that with the parsed copy it gets after reloading postgresql.conf. -- Jim C. Nasby, Sr. Engineering Consultant jnasby@pervasive.com Pervasive Software http://pervasive.com work: 512-231-6117 vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461
Jim Nasby wrote: > If memory serves, we also wanted to have the postmaster log a warning > if it reloaded postgresql.conf and found values that had changed but > wouldn't take effect until restart. It already does that. -- Peter Eisentraut http://developer.postgresql.org/~petere/