Thread: Re: src/tools/pginclude considered harmful (was Re:

Re: src/tools/pginclude considered harmful (was Re:

From
Bruce Momjian
Date:
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Tom Lane wrote:
> >> BTW, one of the remaining holes in pgrminclude is that it compiles with
> >> -fsyntax-only, which apparently causes it to fail to detect some errors
> >> of significance --- I assume that's how it managed to foul up lmgr.c,
> >> inet_net_ntop.c, etc.
> 
> > But I do run a full compile and regression before commit, so that should
> > have caught it even if pgrminclude didn't.
> 
> Doesn't catch warnings (unless you add -Werror during the build, which
> will have problems with the remaining expected warnings...)

/tools/pgtest always greps out the warnings and displays them at the end
of the regression tests.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +