Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: [PATCHES] c.h is the problem of msvc.

Re: [PATCHES] c.h is the problem of msvc.

From
Tom Lane
Date:
"Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
> --- src/include/c.h.orig    Sat Jul 15 01:38:59 2006
> +++ src/include/c.h    Sat Jul 15 01:40:04 2006
> @@ -60,7 +60,9 @@
>  #if defined(_MSC_VER) || defined(__BORLANDC__)
>  #define    WIN32_ONLY_COMPILER
>  #define errcode __vc_errcode
> +#if (_MSC_VER > 1400)
>  #include <crtdefs.h>
> +#endif
>  #undef errcode
>  #endif
>  

This patch certainly looks like it will break the __BORLANDC__ build ...
        regards, tom lane

Re: [PATCHES] c.h is the problem of msvc.

From
"Hiroshi Saito"
Date:
Ooops,
I am uncertain at the reason for not knowing __BORLANDC__...
It will be sure if __BORLANDC__ has the definition. 
Thanks.

Regards,
Hiroshi Saito

From: "Tom Lane"


> "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
>> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
>> +++ src/include/c.h Sat Jul 15 01:40:04 2006
>> @@ -60,7 +60,9 @@
>>  #if defined(_MSC_VER) || defined(__BORLANDC__)
>>  #define WIN32_ONLY_COMPILER
>>  #define errcode __vc_errcode
>> +#if (_MSC_VER > 1400)
>>  #include <crtdefs.h>
>> +#endif
>>  #undef errcode
>>  #endif
>>  
> 
> This patch certainly looks like it will break the __BORLANDC__ build ...
> 
> regards, tom lane

Re: [PATCHES] c.h is the problem of msvc.

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Hiroshi Saito wrote:
> Ooops,
> I am uncertain at the reason for not knowing __BORLANDC__...
> It will be sure if __BORLANDC__ has the definition. 
> Thanks.
> 
> Regards,
> Hiroshi Saito
> 
> From: "Tom Lane"
> 
> 
> > "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
> >> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
> >> +++ src/include/c.h Sat Jul 15 01:40:04 2006
> >> @@ -60,7 +60,9 @@
> >>  #if defined(_MSC_VER) || defined(__BORLANDC__)
> >>  #define WIN32_ONLY_COMPILER
> >>  #define errcode __vc_errcode
> >> +#if (_MSC_VER > 1400)
> >>  #include <crtdefs.h>
> >> +#endif
> >>  #undef errcode
> >>  #endif
> >>  
> > 
> > This patch certainly looks like it will break the __BORLANDC__ build ...
> > 
> > regards, tom lane

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +

Re: [PATCHES] c.h is the problem of msvc.

From
Bruce Momjian
Date:
Clarification, the attached version with the BORLAND adjustment is the
one that was applied.

---------------------------------------------------------------------------

Bruce Momjian wrote:
>
> Patch applied.  Thanks.
>
> ---------------------------------------------------------------------------
>
>
> Hiroshi Saito wrote:
> > Ooops,
> > I am uncertain at the reason for not knowing __BORLANDC__...
> > It will be sure if __BORLANDC__ has the definition.
> > Thanks.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
--- src/include/c.h.orig    Sat Jul 15 01:38:59 2006
+++ src/include/c.h    Sat Jul 15 01:40:04 2006
@@ -60,7 +60,9 @@
 #if defined(_MSC_VER) || defined(__BORLANDC__)
 #define    WIN32_ONLY_COMPILER
 #define errcode __vc_errcode
+#if defined(__BORLANDC__) || (_MSC_VER > 1400)
 #include <crtdefs.h>
+#endif
 #undef errcode
 #endif