Thread: Re: [PATCHES] Magic block for modules

Martijn van Oosterhout <kleptog@svana.org> writes:
> On Sun, May 07, 2006 at 08:21:43PM -0400, Tom Lane wrote:
>> I'm pretty sure we had agreed that magic blocks should be required;
>> otherwise this check will accomplish little.

> Sure, I just didn't want to break every module in one weekend. I was
> thinking of adding it with LOG level now, send a message on -announce
> saying that at the beginning of the 8.2 freeze it will be an ERROR.
> Give people time to react.

Now that the magic-block patch is in, we need to revisit this bit of the
discussion.  I'm for making lack of a magic block an ERROR immediately.
I don't see the point of waiting; in fact, if we wait till freeze we'll
just make the breakage more concentrated.  At the very least it ought
to be a WARNING immediately, because a LOG message is just not visible
enough.

Comments?
        regards, tom lane

On Tue, May 30, 2006 at 06:20:33PM -0400, Tom Lane wrote:
> Now that the magic-block patch is in, we need to revisit this bit of the
> discussion.  I'm for making lack of a magic block an ERROR immediately.
> I don't see the point of waiting; in fact, if we wait till freeze we'll
> just make the breakage more concentrated.  At the very least it ought
> to be a WARNING immediately, because a LOG message is just not visible
> enough.

If you like I can send a patch that adds it to all of contrib and some
of the other places required so that make check passes...

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

Martijn van Oosterhout <kleptog@svana.org> writes:
> If you like I can send a patch that adds it to all of contrib and some
> of the other places required so that make check passes...

Think I got them all already:
http://archives.postgresql.org/pgsql-committers/2006-05/msg00384.php
but if you see any I missed...
        regards, tom lane