Thread: Duplicate definition of LOCALEDIR

LOCALEDIR is defined in

src/port/pg_config_paths.h
src/include/pg_config.h

but one of them should be enough.  (May be dependent on --enable-nls.)  Which 
one should be removed?

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

On Mon, May 22, 2006 at 12:17:33PM +0200, Peter Eisentraut wrote:
> LOCALEDIR is defined in
>
> src/port/pg_config_paths.h
> src/include/pg_config.h
>
> but one of them should be enough.  (May be dependent on --enable-nls.)  Which
> one should be removed?

I'd suggest the version in pg_config. Both are ultimatly generated by
configure, but LOCALEDIR is the only directory definition that appears
in pg_config.h.

The fix is simple: remove the AC_DEFINE_UNQUOTED(LOCALEDIR, ...) from
programs/config.h. localedir is still defined.

The odd thing is that there are two paths defined, $localedir and
$exp_localedir, which are not the same and pg_config.h gets one and
pg_config_paths.h gets the other.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

Martijn van Oosterhout <kleptog@svana.org> writes:
> The odd thing is that there are two paths defined, $localedir and
> $exp_localedir, which are not the same and pg_config.h gets one and
> pg_config_paths.h gets the other.

It looks to me like $localedir is literally "${prefix}/share/locale",
while exp_localedir has the full path (ie, the expanded contents of
$prefix).  Better be careful about assuming they are redundant.

The correct solution to this might be to rename the downstream
variables to make it clearer what's what.
        regards, tom lane