Thread: latest pgcrypto patches cause compile errors
looks like the latest pgcrypto-patches that just got applied cause widespread failures on the buildfarm machines: http://www.pgbuildfarm.org/cgi-bin/show_status.pl Stefan
On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote: > looks like the latest pgcrypto-patches that just got applied cause > widespread failures on the buildfarm machines: > > http://www.pgbuildfarm.org/cgi-bin/show_status.pl Seems like Bruce forgot to 'cvs add' new files... -- marko
Marko Kreen wrote: > On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote: > > looks like the latest pgcrypto-patches that just got applied cause > > widespread failures on the buildfarm machines: > > > > http://www.pgbuildfarm.org/cgi-bin/show_status.pl > > Seems like Bruce forgot to 'cvs add' new files... All new files added, and I think all the pgcrypto patches are now applied to CVS. I just added the openssl version patch, I see the IMMUTABLE patch is already in, and I see the autoconfiguration stuff is already in. Is there anything else outstanding for pgcrypto? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote: > All new files added, and I think all the pgcrypto patches are now > applied to CVS. I just added the openssl version patch, I see the > IMMUTABLE patch is already in, and I see the autoconfiguration stuff is > already in. > > Is there anything else outstanding for pgcrypto? No, we are fully synched now. That leaves only 2 things in my TODO list for 8.1: - New documentation. - I've spotted a few buggy comments in new code. Fix them. -- marko
On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote: > Marko Kreen wrote: > > On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote: > > > looks like the latest pgcrypto-patches that just got applied cause > > > widespread failures on the buildfarm machines: > > > > > > http://www.pgbuildfarm.org/cgi-bin/show_status.pl > > > > Seems like Bruce forgot to 'cvs add' new files... > > All new files added, and I think all the pgcrypto patches are now > applied to CVS. I just added the openssl version patch, I see the > IMMUTABLE patch is already in, and I see the autoconfiguration stuff is > already in. > > Is there anything else outstanding for pgcrypto? I see from buildfarm, that pgcrypto fails to build on a non-OpenSSL machine. The reason for it is a stale openssl/bn.h include in pgp-pubdec.c. I did not spot it, as even for --without-openssl build I still had OpenSSL intalled. -- marko
Attachment
Marko Kreen wrote: > On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote: > > Marko Kreen wrote: > > > On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote: > > > > looks like the latest pgcrypto-patches that just got applied cause > > > > widespread failures on the buildfarm machines: > > > > > > > > http://www.pgbuildfarm.org/cgi-bin/show_status.pl > > > > > > Seems like Bruce forgot to 'cvs add' new files... > > > > All new files added, and I think all the pgcrypto patches are now > > applied to CVS. I just added the openssl version patch, I see the > > IMMUTABLE patch is already in, and I see the autoconfiguration stuff is > > already in. > > > > Is there anything else outstanding for pgcrypto? > > I see from buildfarm, that pgcrypto fails to build on a > non-OpenSSL machine. The reason for it is a stale openssl/bn.h > include in pgp-pubdec.c. I did not spot it, as even for > --without-openssl build I still had OpenSSL intalled. Removed from CVS. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote: > Marko Kreen wrote: > > I see from buildfarm, that pgcrypto fails to build on a > > non-OpenSSL machine. The reason for it is a stale openssl/bn.h > > include in pgp-pubdec.c. I did not spot it, as even for > > --without-openssl build I still had OpenSSL intalled. > > Removed from CVS. One more failure: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=cicada&dt=2005-07-10%2017:39:18 I think this is because we don't have -lz in SHLIB_LINK. Following patch fixes it. -- marko
On Sun, Jul 10, 2005 at 09:10:29PM +0300, Marko Kreen wrote: > On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote: > > Marko Kreen wrote: > > > I see from buildfarm, that pgcrypto fails to build on a > > > non-OpenSSL machine. The reason for it is a stale openssl/bn.h > > > include in pgp-pubdec.c. I did not spot it, as even for > > > --without-openssl build I still had OpenSSL intalled. > > > > Removed from CVS. > > One more failure: > > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=cicada&dt=2005-07-10%2017:39:18 > > I think this is because we don't have -lz in SHLIB_LINK. > Following patch fixes it. Here's the patch. -- marko
Attachment
Patch applied. Thanks. --------------------------------------------------------------------------- Marko Kreen wrote: > On Sun, Jul 10, 2005 at 09:10:29PM +0300, Marko Kreen wrote: > > On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote: > > > Marko Kreen wrote: > > > > I see from buildfarm, that pgcrypto fails to build on a > > > > non-OpenSSL machine. The reason for it is a stale openssl/bn.h > > > > include in pgp-pubdec.c. I did not spot it, as even for > > > > --without-openssl build I still had OpenSSL intalled. > > > > > > Removed from CVS. > > > > One more failure: > > > > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=cicada&dt=2005-07-10%2017:39:18 > > > > I think this is because we don't have -lz in SHLIB_LINK. > > Following patch fixes it. > > Here's the patch. > > -- > marko > [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073