Postgres Pro
Downloads
Home   >   mailing lists

Thread: New compile warnings in CVS

New compile warnings in CVS

From
Bruce Momjian
Date:
I just updated my CVS copy and am seeing four new warnings from
pgstat.c:pgstat.c:2352: warning: variable `dbentry' might be clobbered by`longjmp' or `vfork'pgstat.c:2360: warning:
variable`havebackends' might be clobbered by`longjmp' or `vfork'pgstat.c:2362: warning: variable `use_mcxt' might be
clobberedby`longjmp' or `vfork'pgstat.c:2363: warning: variable `mcxt_flags' might be clobbered by`longjmp' or `vfork'
 

Any ideas on this?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073

Re: New compile warnings in CVS

From
Bruce Momjian
Date:
Bruce Momjian wrote:
> I just updated my CVS copy and am seeing four new warnings from
> pgstat.c:
>     
>     pgstat.c:2352: warning: variable `dbentry' might be clobbered by
>     `longjmp' or `vfork'
>     pgstat.c:2360: warning: variable `havebackends' might be clobbered by
>     `longjmp' or `vfork'
>     pgstat.c:2362: warning: variable `use_mcxt' might be clobbered by
>     `longjmp' or `vfork'
>     pgstat.c:2363: warning: variable `mcxt_flags' might be clobbered by
>     `longjmp' or `vfork'
> 
> Any ideas on this?

Oh this is BSD/OS 4.3 using gcc:
gcc version 2.95.3 20010315 (release)

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073

Re: New compile warnings in CVS

From
Tom Lane
Date:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I just updated my CVS copy and am seeing four new warnings from
> pgstat.c:
>     pgstat.c:2352: warning: variable `dbentry' might be clobbered by
>     `longjmp' or `vfork'
>     pgstat.c:2360: warning: variable `havebackends' might be clobbered by
>     `longjmp' or `vfork'
>     pgstat.c:2362: warning: variable `use_mcxt' might be clobbered by
>     `longjmp' or `vfork'
>     pgstat.c:2363: warning: variable `mcxt_flags' might be clobbered by
>     `longjmp' or `vfork'

No doubt this is from the PG_TRY that Neil added a couple days ago.
I think he is going to take it out again in favor of using AllocateFile,
so ignore the warnings for now (they're obviously bogus anyway).
        regards, tom lane

Re: New compile warnings in CVS

From
Neil Conway
Date:
On Wed, 2004-10-27 at 03:57, Tom Lane wrote:
> No doubt this is from the PG_TRY that Neil added a couple days ago.
> I think he is going to take it out again in favor of using AllocateFile,
> so ignore the warnings for now (they're obviously bogus anyway).

Sorry, I didn't see those compile warnings locally (using GCC 3.3).

I'll send the patch for AllocateFile() to -patches shortly.

-Neil